Pass scratch directory to underlying unwrapper #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tophu.multiscale_unwrap()` may be passed the path of a scratch directory in which to put its intermediate outputs. Previously, it did not communicate this to the underlying unwrap callback functor, though, so the unwrapper would just put its scratch outputs in the default temporary directory. This is undesirable because: * The user may want control over where all scratch outputs are written in order to avoid writing to drives with low bandwidth or low available disk space. * The user may want intermediate outputs to persist in a known location after unwrapping for debugging purposes. This update causes the scratch directory location to be propagated to the underlying unwrapper in order to address this issue.
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 97.86% 97.86% -0.01%
==========================================
Files 9 9
Lines 797 796 -1
==========================================
- Hits 780 779 -1
Misses 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tophu.multiscale_unwrap()may be passed the path of a scratch directory in which to put its intermediate outputs. Previously, it did not communicate this to the underlying unwrap callback functor, though, so the unwrapper would just put its scratch outputs in the default temporary directory.This is undesirable because:
This update causes the scratch directory location to be propagated to the underlying unwrapper in order to address this issue.