feat(rental-agreement): Project structure & minimal functionality #16214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eement-application
This reverts commit fda88fb.
…eement-application
…eement-application
…eement-application
…sland.is into rental-agreement-application
…ardcoded text to message translation text.
…eement-application
WalkthroughThe changes in this pull request introduce a new application type, Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
addi
changed the title
…sland.is into rental-agreement-application
…eement-application
…eement-application
…eement-application
…eement-application
* Add and update section id's as route enums. * Update routing for summary change buttons. * Fix lint warnings * Conditonal render of securityDeposit section. Console log cleanup. * Update summary render for security deposit and file upload. * Add uploaded files to summary w. link * Add correct links to all items in summary. * Fix linter warnings
…eement-application
…eement-application
…eement-application
* Add alert message to summary. Cleanup components. Other minor fixes. * Reorder imports for consistency
…eement-application
…eement-application
* Add alert message to summary. Cleanup components. Other minor fixes. * Reorder imports for consistency * Add info about the signing process and list of signees * Update links to uploaded files * Add checkbox for continue to signing statement. * Remove console logs. * Remove unused import.
…eement-application
…eement-application
* Add alert message to summary. Cleanup components. Other minor fixes. * Reorder imports for consistency * Add info about the signing process and list of signees * Update links to uploaded files * Add checkbox for continue to signing statement. * Remove console logs. * Remove unused import. * Update signature info screen and add signing screen. * Add search company nationalIdWithName in table repeater for landlords and tenants * Rename files and components for signing screen
…idations (#17519) * Add validation in dataSchema for fire protection inputs. * Add validation in dataSchema for other fees. * Fix dataschema name for signatureInfo.
* Add validation in dataSchema for fire protection inputs. * Add validation in dataSchema for other fees. * Add validation for inputs based on payment method chosen. * Update README.md with info about localization in Contentful. * Update summary for payment method and format outputs.
…eement-application
…eement-application
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
…eement-application
…eement-application
…eement-application
…eement-application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rental-agreement project structure & minimal functionality
This is pretty much just wireframe code around a new application system form.
Locked behind a feature flag created in ConfigCat and added to @island.is/feature-flags package as per instructions in github docs.
Why
We want to get this code in so we can start developing in a better workflow, small PRs, QA and such.
Checklist:
Summary by CodeRabbit
New Features
Configuration Updates
Enhancements