Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Run lint --fix with dirtybot #17619

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AndesKrrrrrrrrrrr
Copy link
Member

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr commented Jan 22, 2025

Continued from #17538

This reverts commit 27c57ef.


Copy link
Contributor

coderabbitai bot commented Jan 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@datadog-island-is
Copy link

datadog-island-is bot commented Jan 22, 2025

Datadog Report

All test runs 361ff4d 🔗

8 Total Test Services: 0 Failed, 7 Passed
➡️ Test Sessions change in coverage: 13 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 6.91s 1 no change Link
application-system-api 0 0 0 46 0 2m 10.68s 1 no change Link
application-template-api-modules 0 0 0 96 0 0s N/A Link
application-templates-financial-aid 0 0 0 11 0 30.74s 1 no change Link
judicial-system-backend 0 0 0 20123 0 16m 5.93s 1 no change Link
services-auth-delegation-api 0 0 0 270 0 3m 28.78s 1 no change Link
services-auth-personal-representative 0 0 0 0 0 282.41ms 1 no change Link
web 0 0 0 84 0 52.92s 1 no change Link

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.47%. Comparing base (1b76676) to head (573d31b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17619   +/-   ##
=======================================
  Coverage   34.47%   34.47%           
=======================================
  Files        6492     6492           
  Lines      142634   142634           
  Branches    41125    41125           
=======================================
  Hits        49173    49173           
  Misses      93461    93461           
Flag Coverage Δ
air-discount-scheme-backend 48.13% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.33% <ø> (ø)
api-catalogue-services 75.81% <ø> (ø)
api-domains-air-discount-scheme 37.84% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.46% <ø> (ø)
api-domains-criminal-record 47.73% <ø> (ø)
api-domains-driving-license 44.74% <ø> (ø)
api-domains-education 31.03% <ø> (ø)
api-domains-email-signup 40.16% <ø> (ø)
api-domains-health-insurance 35.09% <ø> (ø)
api-domains-mortgage-certificate 34.91% <ø> (ø)
api-domains-payment-schedule 41.98% <ø> (ø)
application-api-files 61.73% <ø> (ø)
application-core 75.68% <ø> (ø)
application-templates-accident-notification 27.60% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.79% <ø> (ø)
application-templates-driving-license 18.15% <ø> (ø)
application-templates-estate 13.58% <ø> (ø)
application-templates-example-payment 24.66% <ø> (ø)
application-templates-financial-aid 14.99% <ø> (ø)
application-templates-general-petition 23.11% <ø> (ø)
application-templates-inheritance-report 6.59% <ø> (ø)
application-templates-marriage-conditions 14.80% <ø> (ø)
application-templates-mortgage-certificate 43.73% <ø> (ø)
application-templates-new-primary-school 20.60% <ø> (ø)
application-templates-no-debt-certificate 51.23% <ø> (ø)
application-templates-parental-leave 29.80% <ø> (ø)
application-types 6.47% <ø> (ø)
application-ui-components 1.17% <ø> (ø)
application-ui-shell 22.00% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 31.69% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 28.88% <ø> (ø)
clients-driving-license 40.60% <ø> (ø)
clients-driving-license-book 43.69% <ø> (ø)
clients-financial-statements-inao 49.41% <ø> (ø)
clients-license-client 1.26% <ø> (ø)
clients-middlewares 73.14% <ø> (+0.32%) ⬆️
clients-regulations 42.66% <ø> (ø)
clients-rsk-company-registry 31.18% <ø> (ø)
clients-rsk-personal-tax-return 38.32% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.14% <ø> (ø)
clients-zendesk 49.64% <ø> (ø)
cms 0.38% <ø> (ø)
cms-translations 38.80% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.16% <ø> (ø)
contentful-apps 4.56% <ø> (ø)
dokobit-signing 61.48% <ø> (ø)
email-service 59.51% <ø> (ø)
feature-flags 90.24% <ø> (ø)
file-storage 45.10% <ø> (ø)
financial-aid-backend 51.35% <ø> (ø)
financial-aid-shared 17.88% <ø> (ø)
icelandic-names-registry-backend 55.04% <ø> (ø)
infra-nest-server 48.06% <ø> (ø)
infra-tracing 69.94% <ø> (ø)
island-ui-core 30.34% <ø> (ø)
judicial-system-api 20.22% <ø> (ø)
judicial-system-audit-trail 68.36% <ø> (ø)
judicial-system-formatters 78.49% <ø> (ø)
judicial-system-message 66.16% <ø> (ø)
judicial-system-message-handler 47.72% <ø> (ø)
judicial-system-scheduler 70.99% <ø> (ø)
judicial-system-types 38.69% <ø> (ø)
judicial-system-web 27.89% <ø> (ø)
license-api 42.75% <ø> (ø)
localization 10.15% <ø> (ø)
logging 58.02% <ø> (ø)
message-queue 67.76% <ø> (ø)
nest-audit 65.78% <ø> (ø)
nest-aws 51.93% <ø> (ø)
nest-config 75.92% <ø> (ø)
nest-core 53.16% <ø> (ø)
nest-feature-flags 50.56% <ø> (ø)
nest-problem 45.52% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 50.63% <ø> (ø)
nova-sms 60.77% <ø> (ø)
portals-admin-regulations-admin 1.80% <ø> (ø)
portals-core 19.62% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-public-api 49.33% <ø> (ø)
services-sessions 65.15% <ø> (ø)
services-university-gateway 49.28% <ø> (ø)
services-user-profile 56.86% <ø> (ø)
shared-form-fields 33.40% <ø> (ø)
shared-mocking 58.64% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 89.65% <ø> (ø)
shared-utils 28.67% <ø> (ø)
skilavottord-ws 23.97% <ø> (ø)
web 2.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b76676...573d31b. Read the comment docs.

@AndesKrrrrrrrrrrr AndesKrrrrrrrrrrr added the test everything 💀 test & build everything 💀 label Jan 29, 2025
AndesKrrrrrrrrrrr and others added 2 commits January 29, 2025 14:47
  nx run-many --target lint --fix --parallel 2 --projects=application-templates-social-insurance-administration-additional-support-for-the-elderly,application-templates-transport-authority-order-vehicle-registration-certificate,application-templates-social-insurance-administration-household-supplement,application-templates-transport-authority-digital-tachograph-workshop-card,application-templates-transport-authority-digital-tachograph-company-card,application-templates-transport-authority-digital-tachograph-drivers-card,application-templates-social-insurance-administration-pension-supplement,application-templates-transport-authority-anonymity-in-vehicle-registry,application-templates-transport-authority-transfer-of-vehicle-ownership,application-templates-parliamentary-list-creation,application-templates-parliamentary-list-signing,application-templates-presidential-list-creation,application-templates-social-insurance-administration-old-age-pension,application-templates-transport-authority-order-vehicle-license-plate,application-templates-presidential-list-signing,application-templates-social-insurance-administration-death-benefits,application-templates-transport-authority-change-co-owner-of-vehicle,application-templates-transport-authority-change-operator-of-vehicle,fiancial-statement-individual-election,application-templates-children-residence-change-v2,application-templates-social-insurance-administration-income-plan,clients-university-application-agricultural-university-of-iceland,application-templates-transport-authority-license-plate-renewal,application-templates-inao-financial-statement-political-party,clients-university-application-iceland-university-of-the-arts,api-domains-administration-of-occupational-safety-and-health,application-templates-directorate-of-immigration-citizenship,application-templates-driving-license-book-update-instructor,clients-transport-authority-digital-tachograph-drivers-card,application-templates-social-insurance-administration-core,application-templates-aosh-transfer-of-machine-ownership,clients-administration-of-occupational-safety-and-health,financial-statement-cemetery,api-domains-icelandic-government-institution-vacancies,application-templates-complaints-to-althingi-ombudsman,application-templates-driving-instructor-registrations,application-templates-aosh-work-accident-notification,clients-university-application-university-of-akureyri,application-templates-aosh-change-machine-supervisor,application-templates-european-health-insurance-card,application-templates-healthcare-license-certificate,clients-university-application-university-of-iceland,api-domains-financial-statement-individual-election,api-domains-official-journal-of-iceland-application,clients-health-insurance,clients-university-application-reykjavik-university,application-templates-document-provider-onboarding,application-templates-health-insurance-declaration,clients-icelandic-government-institution-vacancies,clients-transport-authority-vehicle-plate-ordering,application-templates-aosh-request-for-inspection,application-templates-driving-assessment-approval,application-templates-driving-school-confirmation,application-templates-funding-government-projects,application-templates-official-journal-of-iceland,clients-transport-authority-vehicle-plate-renewal,clients-university-application-bifrost-university,clients-rights-portal,clients-transport-authority-vehicle-owner-change,application-templates-aosh-register-new-machine,application-templates-data-protection-complaint,application-templates-driving-license-duplicate,application-templates-financial-statements-inao,application-templates-institution-collaboration,clients-official-journal-of-iceland-application,clients-university-application-holar-university,application-templates-aosh-street-registration,application-templates-grindavik-housing-buyout,application-templates-public-debt-payment-plan,clients-transport-authority-vehicle-codetables,application-templates-aosh-deregister-machine,application-templates-driving-learners-permit,application-templates-general-fishing-license,clients-transport-authority-vehicle-infolocks,clients-transport-authority-vehicle-operators,portals-my-pages-education-student-assessment,portals-my-pages-social-insurance-maintenance,application-templates-alcohol-tax-redemption,application-templates-healthcare-work-permit,clients-transport-authority-vehicle-printing,services-auth-personal-representative-public,application-templates-accident-notification,application-templates-announcement-of-death,application-templates-mortgage-certificate,clients-official-journal-of-iceland,application-templates-family-matters-core,application-templates-marriage-conditions,application-templates-no-debt-certificate,api-domains-financial-statement-cemetery,api-domains-municipalities-financial-aid,application-templates-inheritance-report,application-templates-new-primary-school,application-templates-passport-annulment,application-templates-reference-template,api-domains-official-journal-of-iceland,application-templates-operating-license,clients-district-commissioners-licenses,clients-social-insurance-administration,api-domains-housing-benefit-calculator,application-templates-general-petition,application-templates-health-insurance,application-templates-secondary-school,portals-admin-icelandic-names-registry,portals-my-pages-occupational-licenses,api-domains-financial-statements-inao,application-templates-criminal-record,application-templates-driving-license,application-templates-example-payment,clients-ums-cost-of-living-calculator,portals-my-pages-signature-collection,services-auth-personal-representative,api-domains-icelandic-names-registry,api-domains-national-registry-x-road,api-domains-occupational-licenses-v2,application-templates-parental-leave,clients-municipalities-financial-aid,api-domains-intellectual-properties,application-templates-car-recycling,application-templates-financial-aid,application-templates-login-service,judicial-system-digital-mailbox-api,application-templates-energy-funds,application-templates-home-support,clients-directorate-of-immigration,clients-housing-benefit-calculator,portals-admin-signature-collection,portals-my-pages-education-license,portals-shared-modules-delegations,regulations-admin-backend,api-domains-directorate-of-labour,api-domains-occupational-licenses,api-domains-watson-assistant-chat,clients-data-protection-complaint,clients-financial-statements-inao,contentful-role-permissions,portals-admin-air-discount-scheme,portals-my-pages-education-career,portals-my-pages-education-degree,api-domains-driving-license-book,api-domains-mortgage-certificate,api-domains-signature-collection,api-domains-umbodsmadur-skuldara,application-template-api-modules,application-templates-university,icelandic-names-registry-backend,portals-admin-application-system,services-contentful-entry-tagger,api-consultation-portal,api-domains-air-discount-scheme,api-domains-transport-authority,clients-adr-and-machine-license,clients-intellectual-properties,clients-judicial-administration,clients-rsk-personal-tax-return,island-ui-vanilla-extract-utils,judicial-system-message-handler,portals-admin-document-provider,portals-admin-regulations-admin,api-domains-disability-license,api-domains-endorsement-system,api-domains-health-directorate,api-domains-university-careers,api-domains-university-gateway,application-templates-passport,clients-university-gateway-api,clients-vehicle-service-fjs-v1,delegation-admin,icelandic-names-registry-types,portals-my-pages-law-and-order,api-domains-aircraft-registry,api-domains-document-provider,api-domains-national-registry,api-domains-regulations-admin,application-templates-id-card,clients-ultraviolet-radiation,my-pages-air-discount,portals-my-pages-applications,portals-my-pages-restrictions,api-domains-company-registry,api-domains-health-insurance,api-domains-housing-benefits,api-domains-payment-schedule,api-domains-secondary-school,api-domains-social-insurance,application-templates-estate,application-templates-p-sign,clients-driving-license-book,clients-hms-housing-benefits,clients-national-registry-v2,clients-national-registry-v3,clients-rsk-company-registry,clients-signature-collection,content-search-index-manager,content-search-indexer-types,judicial-system-court-client,portals-my-pages-information,services-auth-delegation-api,air-discount-scheme-backend,api-domains-criminal-record,api-domains-driving-license,api-domains-fishing-license,api-domains-license-service,application-template-loader,clients-air-discount-scheme,clients-auth-delegation-api,clients-consultation-portal,judicial-system-audit-trail,services-university-gateway,air-discount-scheme-consts,api-domains-communications,api-domains-content-search,clients-althingi-ombudsman,clients-disability-license,clients-health-directorate,clients-judicial-system-sp,clients-smart-solutions-v2,clients-university-careers,judicial-system-formatters,portals-admin-service-desk,portals-my-pages-constants,portals-my-pages-documents,portals-my-pages-education,portals-my-pages-petitions,services-user-notification,air-discount-scheme-types,aircraft-registry,api-domains-api-catalogue,api-domains-law-and-order,api-domains-notifications,api-domains-rights-portal,api-domains-ship-registry,api-domains-work-machines,application-ui-components,clients-document-provider,clients-regulations-admin,clients-rsk-relationships,clients-user-notification,clients-work-accident-ver,financial-aid-web-osk-e2e,judicial-system-scheduler,portals-admin-form-system,portals-my-pages-licenses,portals-my-pages-sessions,services-endorsements-api,api-domains-email-signup,api-domains-energy-funds,api-domains-user-profile,clients-payment-schedule,clients-secondary-school,clients-vehicles-mileage,clients-workpoint-arborg,external-contracts-tests,portals-my-pages-consent,portals-my-pages-finance,portals-my-pages-graphql,services-auth-public-api,services-xroad-collector,air-discount-scheme-api,air-discount-scheme-web,api-domains-application,api-domains-file-upload,api-domains-regulations,api/domains/form-system,application-api-history,application-api-payment,application-system-form,clients-auth-public-api,clients-criminal-record,clients-driving-license,clients-firearm-license,clients-fishing-license,clients-hunting-license,financial-aid-web-veita,judicial-system-backend,judicial-system-lawyers,judicial-system-message,judicial-system-xrd-api,portals-admin-ids-admin,portals-my-pages-assets,portals-my-pages-health,services-auth-admin-api,services-search-indexer,api-catalogue-services,api-domains-auth-admin,api-domains-fiskistofa,api-domains-statistics,application-system-api,clients-auth-admin-api,clients-ehic-client-v1,clients-license-client,clients-smartsolutions,content-search-indexer,content-search-metrics,content-search-toolkit,financial-aid-open-api,judicial-system-consts,portals-admin-petition,api-catalogue-elastic,api-domains-documents,api-domains-education,api-domains-hms-loans,api-domains-syslumenn,application-api-files,application-ui-fields,clients-car-recycling,clients-charge-fjs-v2,clients-work-machines,financial-aid-backend,financial-aid-web-osk,judicial-system-types,portals-my-pages-core,services-auth-ids-api,services-auth-testing,services-user-profile,ship-registry,api-catalogue-consts,api-domains-identity,api-domains-passport,api-domains-sessions,api-domains-vehicles,application-api-core,application-ui-forms,application-ui-shell,clients-auth-ids-api,clients-documents-v2,clients-energy-funds,clients-user-profile,financial-aid-shared,github-actions-cache,infra-express-server,island-ui-contentful,judicial-system-auth,license-api,services-form-system,api-catalogue-types,api-domains-finance,api-domains-payment,application-graphql,application-testing,clients-middlewares,clients-mms,clients-regulations,consultation-portal,form-system-client,island-ui-storybook,judicial-system-api,judicial-system-web,react-feature-flags,shared-translations,skilavottord-consts,api-domains-assets,clients-finance-v2,clients-fiskistofa,clients-statistics,nest-feature-flags,portals-admin-core,reference-next-app,services-documents,shared-form-fields,skilavottord-types,testing-containers,university-gateway,application-types,application-utils,clients-documents,clients-hms-loans,clients-mms-frigg,clients-mms-grade,clients-passports,clients-syslumenn,financial-aid-api,infra-nest-server,infra-next-server,reference-backend,residence-history,services-sessions,shared-components,api-domains-auth,application-core,clients-identity,clients-islykill,clients-sessions,clients-vehicles,cms-translations,download-service,license,react-components,react-spa-shared,service-portal,shared-connected,shared-constants,skilavottord-web,testing-fixtures,auth-nest-tools,clients-finance,clients-zendesk,contentful-apps,dokobit-signing,island-ui-theme,island-ui-utils,nest-dataloader,nest-pagination,skilavottord-ws,user-monitoring,auth-admin-web,clients-assets,clients-p-card,island-ui-core,nest-sequelize,shared-mocking,shared-problem,email-service,feature-flags,infra-metrics,infra-tracing,message-queue,next-ids-auth,portals-admin,react-spa-bff,auth-api-lib,clients-inna,clients-vmst,file-storage,localization,nest-graphql,nest-problem,nest-swagger,portals-core,services-bff,shared-babel,shared-types,shared-utils,testing-nest,auth-scopes,auth-shared,clients-cms,nest-config,regulations,testing-e2e,api-schema,native-app,nest-audit,shared-pii,system-e2e,api-mocks,nest-core,plausible,nest-aws,nova-sms,logging,cache,api,cms,web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test everything 💀 test & build everything 💀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants