feat(user-notifications): Testing client and worker #17709

kksteini · 2025-01-29T11:41:47Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

…national-registry-applications-client

coderabbitai · 2025-01-29T11:41:55Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-29T12:20:37Z

Deployed services: application-system-api,application-system-form,service-portal,service-portal-api,portals-admin,api,web,skilavottord-web,skilavottord-ws,services-documents,island-ui-storybook,download-service,icelandic-names-registry-backend,endorsement-system-api,air-discount-scheme-web,air-discount-scheme-backend,air-discount-scheme-api,regulations-admin-backend,application-system-api-worker,license-api,services-sessions,services-sessions-worker,services-sessions-cleanup,services-university-gateway,services-university-gateway-worker,services-bff-portals-admin,services-bff-portals-my-pages,consultation-portal.
Excluded services: search-indexer-service,user-notification,user-notification-worker,user-notification-cleanup-worker

codecov · 2025-01-29T13:51:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.47%. Comparing base (1b76676) to head (ae8b842).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17709   +/-   ##
=======================================
  Coverage   34.47%   34.47%           
=======================================
  Files        6492     6492           
  Lines      142634   142634           
  Branches    41125    41141   +16     
=======================================
  Hits        49173    49173           
  Misses      93461    93461

Flag	Coverage Δ
air-discount-scheme-backend	`48.13% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`37.84% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.46% <ø> (ø)`
api-domains-criminal-record	`47.73% <ø> (ø)`
api-domains-driving-license	`44.74% <ø> (ø)`
api-domains-education	`31.03% <ø> (ø)`
api-domains-email-signup	`40.16% <ø> (ø)`
api-domains-health-insurance	`35.09% <ø> (ø)`
api-domains-mortgage-certificate	`34.91% <ø> (ø)`
api-domains-payment-schedule	`41.98% <ø> (ø)`
application-api-files	`61.73% <ø> (ø)`
application-core	`75.68% <ø> (ø)`
application-system-api	`38.64% <ø> (+0.02%)`	⬆️
application-templates-accident-notification	`27.60% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.79% <ø> (ø)`
application-templates-driving-license	`18.15% <ø> (ø)`
application-templates-estate	`13.58% <ø> (ø)`
application-templates-example-payment	`24.66% <ø> (ø)`
application-templates-financial-aid	`14.99% <ø> (ø)`
application-templates-general-petition	`23.11% <ø> (ø)`
application-templates-inheritance-report	`6.59% <ø> (ø)`
application-templates-marriage-conditions	`14.80% <ø> (ø)`
application-templates-mortgage-certificate	`43.73% <ø> (ø)`
application-templates-new-primary-school	`20.60% <ø> (ø)`
application-templates-no-debt-certificate	`51.23% <ø> (ø)`
application-templates-parental-leave	`29.89% <ø> (+0.09%)`	⬆️
application-types	`6.47% <ø> (ø)`
application-ui-components	`1.17% <ø> (ø)`
application-ui-shell	`22.00% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.69% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.88% <ø> (ø)`
clients-driving-license	`40.60% <ø> (ø)`
clients-driving-license-book	`43.69% <ø> (ø)`
clients-financial-statements-inao	`49.41% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`73.06% <ø> (+0.24%)`	⬆️
clients-regulations	`42.66% <ø> (ø)`
clients-rsk-company-registry	`31.18% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.14% <ø> (ø)`
clients-zendesk	`49.64% <ø> (ø)`
cms	`0.38% <ø> (ø)`
cms-translations	`38.80% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.56% <ø> (ø)`
dokobit-signing	`61.48% <ø> (ø)`
email-service	`59.51% <ø> (ø)`
feature-flags	`90.24% <ø> (ø)`
file-storage	`45.10% <ø> (ø)`
financial-aid-backend	`51.35% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
icelandic-names-registry-backend	`55.04% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.94% <ø> (ø)`
island-ui-core	`30.34% <ø> (ø)`
judicial-system-api	`20.22% <ø> (ø)`
judicial-system-audit-trail	`68.36% <ø> (ø)`
judicial-system-backend	`55.78% <ø> (ø)`
judicial-system-formatters	`78.49% <ø> (ø)`
judicial-system-message	`66.16% <ø> (ø)`
judicial-system-message-handler	`47.72% <ø> (ø)`
judicial-system-scheduler	`70.99% <ø> (ø)`
judicial-system-types	`38.69% <ø> (ø)`
judicial-system-web	`27.89% <ø> (ø)`
license-api	`42.95% <ø> (+0.20%)`	⬆️
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (ø)`
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`75.92% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`50.56% <ø> (ø)`
nest-problem	`45.52% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`50.63% <ø> (ø)`
nova-sms	`60.77% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.62% <ø> (ø)`
portals-my-pages-core	`0.78% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.49% <ø> (ø)`
services-auth-delegation-api	`58.49% <ø> (ø)`
services-auth-ids-api	`52.47% <ø> (ø)`
services-auth-public-api	`49.33% <ø> (ø)`
services-sessions	`65.15% <ø> (ø)`
services-university-gateway	`49.40% <ø> (+0.12%)`	⬆️
services-user-profile	`56.86% <ø> (ø)`
shared-form-fields	`33.40% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`89.65% <ø> (ø)`
shared-utils	`28.67% <ø> (ø)`
skilavottord-ws	`23.97% <ø> (ø)`
web	`2.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/infra-nest-server/src/lib/processJob.ts	`75.00% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b76676...ae8b842. Read the comment docs.

nx-cloud · 2025-02-03T11:16:44Z

View your CI Pipeline Execution ↗ for commit d639397.

Command	Status	Duration	Result
`nx run-many --projects judicial-system-backend ...`	✅ Succeeded	35m 43s	View ↗
`nx run-many --projects application-system-api -...`	✅ Succeeded	15m 35s	View ↗
`nx run-many --projects clients-regulations-admi...`	✅ Succeeded	1s	View ↗
`nx run-many --projects clients-user-notificatio...`	✅ Succeeded	1s	View ↗
`nx run-many --projects web --target test --para...`	✅ Succeeded	1s	View ↗
`nx run-many --projects skilavottord-ws --target...`	✅ Succeeded	<1s	View ↗
`nx run-many --projects services-auth-personal-r...`	✅ Succeeded	<1s	View ↗
`nx run-many --projects application-templates-so...`	✅ Succeeded	1s	View ↗
`Additional runs (62)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-02-06 12:01:28 UTC

kksteini added 7 commits January 22, 2025 09:56

feat(clients-national-registry-v3-applications): Init

db3f1b5

Merge branch 'main' of github.com:/island-is/island.is into feat/add-…

a327d51

…national-registry-applications-client

Minor name changes

55ec70d

Prepare fake data

719bcb4

Scaffolding worker setup

5840443

Merge branch 'main' of github.com:/island-is/island.is into feat/add-…

0aca773

…national-registry-applications-client

Testing adding to queue

2368de3

kksteini changed the title ~~Feat/add national registry applications client~~ feat(user-notifications): Testing client and worker Jan 29, 2025

kksteini added the deploy-feature Deploys features to dev label Jan 29, 2025

Fix problemdetails in client config

464c396

kksteini added 2 commits January 29, 2025 14:01

Merge branch 'main' into feat/add-national-registry-applications-client

ae8b842

Merge branch 'main' into feat/add-national-registry-applications-client

8b43574

kksteini and others added 9 commits February 3, 2025 14:04

Merge branch 'main' into feat/add-national-registry-applications-client

a40da83

Merge branch 'main' into feat/add-national-registry-applications-client

21b8004

Merge branch 'main' into feat/add-national-registry-applications-client

9f3816a

Merge branch 'main' into feat/add-national-registry-applications-client

111660b

Merge branch 'main' into feat/add-national-registry-applications-client

aad6384

Merge branch 'main' into feat/add-national-registry-applications-client

a3785f7

chore: charts update dirty files

22c638e

Merge branch 'main' into feat/add-national-registry-applications-client

8b00f72

Delete libs/clients/national-registry/v3-applications/src/lib/utils.ts

d639397

kksteini removed the deploy-feature Deploys features to dev label Feb 6, 2025

kksteini closed this Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(user-notifications): Testing client and worker #17709

feat(user-notifications): Testing client and worker #17709

kksteini commented Jan 29, 2025

coderabbitai bot commented Jan 29, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Jan 29, 2025 •

edited

Loading

codecov bot commented Jan 29, 2025 •

edited

Loading

nx-cloud bot commented Feb 3, 2025 •

edited

Loading

feat(user-notifications): Testing client and worker #17709

feat(user-notifications): Testing client and worker #17709

Conversation

kksteini commented Jan 29, 2025

...

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Jan 29, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

github-actions bot commented Jan 29, 2025 • edited Loading

codecov bot commented Jan 29, 2025 • edited Loading

Codecov Report

nx-cloud bot commented Feb 3, 2025 • edited Loading

coderabbitai bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

codecov bot commented Jan 29, 2025 •

edited

Loading

nx-cloud bot commented Feb 3, 2025 •

edited

Loading