feat(web): Digital Iceland mailing list component #17816
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request introduces new components for mailing list thumbnails. The Changes
Sequence Diagram(s)sequenceDiagram
participant CMS as CMS
participant Renderer as webRenderConnectedComponent
participant Grid as GridContainer
participant DIComponent as DigitalIcelandMailingListThumbnailCard
participant Thumbnail as MailingListThumbnailCard
CMS->>Renderer: Provide slice with type "DigitalIcelandMailingListThumbnailCard"
Renderer->>Grid: Wrap component in GridContainer
Grid->>DIComponent: Render DigitalIcelandMailingListThumbnailCard
DIComponent->>DIComponent: Use useI18n to compute texts
DIComponent->>Thumbnail: Pass texts and link props for rendering
Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/components/connected/MailingListThumbnailCard/DigitalIcelandMailingListThumbnailCard.tsx (1)
15-27: Extract default texts to constants for better maintainability.Consider extracting the default texts to named constants to improve readability and maintainability.
+const DEFAULT_TEXTS = { + is: { + heading: 'Fylgstu með því nýjasta', + description: 'Skráðu þig á póstlista Stafræns Íslands og fylgstu með því nýjasta í stafrænni opinberri þjónustu.', + linkLabel: 'Skrá mig á póstlista' + }, + en: { + heading: 'Subscribe', + description: 'Sign up for the Digital Iceland mailing list and stay up to date with the latest in digital public services.', + linkLabel: 'Subscribe to mailing list' + } +} + const headingText = - slice.json?.headingText ?? activeLocale === 'is' - ? 'Fylgstu með því nýjasta' - : 'Subscribe' + slice.json?.headingText ?? DEFAULT_TEXTS[activeLocale].heading const descriptionText = - slice.json?.descriptionText ?? activeLocale === 'is' - ? 'Skráðu þig á póstlista Stafræns Íslands og fylgstu með því nýjasta í stafrænni opinberri þjónustu.' - : 'Sign up for the Digital Iceland mailing list and stay up to date with the latest in digital public services.' + slice.json?.descriptionText ?? DEFAULT_TEXTS[activeLocale].description const linkHref = slice.json?.linkHref const linkLabel = - slice.json?.linkLabel ?? activeLocale === 'is' - ? 'Skrá mig á póstlista' - : 'Subscribe to mailing list' + slice.json?.linkLabel ?? DEFAULT_TEXTS[activeLocale].linkLabel
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/web/components/connected/MailingListThumbnailCard/DigitalIcelandMailingListThumbnailCard.tsx(1 hunks)apps/web/components/connected/MailingListThumbnailCard/MailingListThumbnailCard.tsx(1 hunks)apps/web/components/connected/index.ts(1 hunks)apps/web/utils/richText.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`apps/**/*`: "Confirm that the code adheres to the following...
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/connected/index.tsapps/web/utils/richText.tsxapps/web/components/connected/MailingListThumbnailCard/MailingListThumbnailCard.tsxapps/web/components/connected/MailingListThumbnailCard/DigitalIcelandMailingListThumbnailCard.tsx
🔇 Additional comments (4)
apps/web/components/connected/index.ts (1)
8-8: LGTM!The new export follows the established pattern and maintains consistency with other exports.
apps/web/components/connected/MailingListThumbnailCard/MailingListThumbnailCard.tsx (1)
10-15: LGTM!The component is well-structured with:
- Clear and typed props interface
- Consistent use of island-ui components
- Proper layout and spacing
Also applies to: 17-52
apps/web/components/connected/MailingListThumbnailCard/DigitalIcelandMailingListThumbnailCard.tsx (1)
6-8: LGTM!The component is well-implemented with:
- Type-safe props
- Proper localization handling
- Safe access to slice data with fallbacks
Also applies to: 10-37
apps/web/utils/richText.tsx (1)
20-20: LGTM!The changes are well-implemented with:
- Proper imports
- Consistent component wrapping in GridContainer
- Correct prop passing
Also applies to: 32-32, 207-213
apps/web/components/connected/MailingListThumbnailCard/MailingListThumbnailCard.tsx
Outdated
Show resolved
Hide resolved
|
View your CI Pipeline Execution ↗ for commit c3a0266.
☁️ Nx Cloud last updated this comment at |
mannipje
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Digital Iceland mailing list component
Checklist:
Summary by CodeRabbit