feat(web): WHODAS - Allow for overwriting question text in CMS #17838
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes introduce an optional Changes
Sequence Diagram(s)sequenceDiagram
participant WF as WHODASForm
participant AO as AnswerOption
participant FM as formatMessage
WF->>AO: Check if "text" property exists
alt Text is provided
AO-->>WF: Return text value
else Text is not provided
WF->>FM: Retrieve label via formatMessage
FM-->>WF: Return formatted label
end
WF->>WF: Render radio button with label
Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
View your CI Pipeline Execution ↗ for commit 5deb90e.
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/components/connected/WHODAS/Calculator.tsx (1)
93-99: Consider extracting label generation logic.The label generation logic could be extracted into a separate function for better maintainability and reusability.
+const getAnswerLabel = ( + option: { text?: string; score: number }, + answerIndex: number, + formatMessage: IntlFormatters['formatMessage'] +) => { + return ( + (option.text?.trim() || '') || + formatMessage( + m.answerLabel[String(answerIndex) as keyof typeof m.answerLabel] + ) + ) +} - const label = - option.text || - formatMessage( - m.answerLabel[ - String(answerIndex) as keyof typeof m.answerLabel - ], - ) + const label = getAnswerLabel(option, answerIndex, formatMessage)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/components/connected/WHODAS/Calculator.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`apps/**/*`: "Confirm that the code adheres to the following...
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/connected/WHODAS/Calculator.tsx
🔇 Additional comments (2)
apps/web/components/connected/WHODAS/Calculator.tsx (2)
34-40: LGTM! Type-safe implementation of the text override feature.The optional
textproperty is correctly typed and aligns with TypeScript best practices.
93-99: Consider adding validation for empty text.While the implementation is correct, consider adding validation to handle empty strings in the
textproperty to ensure consistent label display.- const label = - option.text || - formatMessage( - m.answerLabel[ - String(answerIndex) as keyof typeof m.answerLabel - ], - ) + const label = + (option.text?.trim() || '') || + formatMessage( + m.answerLabel[ + String(answerIndex) as keyof typeof m.answerLabel + ], + )✅ Verification successful
Error: No shell scripts or web queries found
Enhance Label Validation for Consistent UI Behavior
- The current logic returns
option.textwithout checking for empty or whitespace strings, which may lead to unwanted UI behavior.- Using a trimmed check (e.g.,
option.text?.trim()) ensures that even strings containing only spaces fall back to the formatted default fromm.answerLabel.- Consider extracting this label-generation logic into a separate function for improved maintainability and reusability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHODAS - Allow for overwriting question text in CMS
Checklist:
Summary by CodeRabbit