Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Misc changes #9

wants to merge 2 commits into from

Conversation

SamGG
Copy link
Contributor

@SamGG SamGG commented Nov 27, 2019

Hi,
I did those changes to help me. Might be interesting to others. Doesn't break anything I think.

  • add suffix to channelRename() in order to change it if needed
  • add options to read.FCS in order to avoid data truncation and the addition of flowCore_XX keywords in the header
  • improve the suffix merging to remove internal ".fcs" in the remaned file name
    Best

add options to read.FCS in order to avoid data truncation and the addition of flowCore_XX keywords
improve the suffix merging to remove internal ".fcs" in the remaned file name
@SamGG
Copy link
Contributor Author

SamGG commented Jun 2, 2020

@ddsouz5 Hi. Could you consider this PR, or alternatively the file changed and copy/paste the changes. Best.

@ddsouz5
Copy link
Contributor

ddsouz5 commented Jun 3, 2020

thanks @SamGG ! @bhhlee , when you have the time, can you quickly review these changes? Just to make sure it doesn't break any of your workflows.

Merge changes from original repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants