Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package/rpm, src/main/bash: refactor Bash scripts #29

Draft
wants to merge 4 commits into
base: develop-3.3
Choose a base branch
from
Draft

package/rpm, src/main/bash: refactor Bash scripts #29

wants to merge 4 commits into from

Conversation

ShamrockLee
Copy link

Status

Just pass shellcheck, but the execution is not tested yet.

Description

  • Change shebangs from #!/bin/bash to #!/usr/bin/env bash
  • Add set -eu -o -pipefail wherever reasonable
  • Use realpath instead of parsing ls -ld and find instead of ls -1 | tr
  • Fix typo in package/rpm/build-rpm.sh: soruce_tmp_dir -> source_tmp_dir
  • Wrap strings with double quotes and use $() instead of ``
  • Make sure all of them run through shellcheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShamrockLee