Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): revert use_new_connection=True #805

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

shcheklein
Copy link
Member

Trying to revert based on #804 (comment)

Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12da0c9
Status: ✅  Deploy successful!
Preview URL: https://033ee68d.datachain-documentation.pages.dev
Branch Preview URL: https://fix-660-revet-change-made-by.datachain-documentation.pages.dev

View logs

@shcheklein shcheklein marked this pull request as ready for review January 9, 2025 04:13
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (5b15006) to head (12da0c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         128      128           
  Lines       11369    11369           
  Branches     1535     1535           
=======================================
  Hits         9942     9942           
  Misses       1048     1048           
  Partials      379      379           
Flag Coverage Δ
datachain 87.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein requested review from skshetry, a team and yathomasi January 9, 2025 04:23
@shcheklein shcheklein merged commit 2364ac2 into main Jan 9, 2025
38 checks passed
@shcheklein shcheklein deleted the fix-660/revet-change-made-by-mistake branch January 9, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants