link/term: .dvc/ (dir) & "internal" #2120
Conversation
jorgeorpinel
changed the title
jorgeorpinel
changed the title
| ## Generating multiple stages | ||
| ## Foreach stages |
There was a problem hiding this comment.
Does everyone agree on this term? Cc @dberenbaum
There was a problem hiding this comment.
foearch should be code-inlined I think ... There was an option like "Something (foreach)" - I would personally prefer that one
There was a problem hiding this comment.
I can't find any suggestion like "Something (foreach)" but I'm fine with "foreach stages"
There was a problem hiding this comment.
I think the "Something" was "Loop" but I argued we should avoid that direct reference.
Went for quoted foreach stages — a minor issue is how it looks in the ToC nav:
UPDATE: This change is now in #2124.
content/linked-terms.js
Outdated
| matches: '.dvcignore', | ||
| url: '/doc/user-guide/project-structure/dvcignore-files' |
There was a problem hiding this comment.
Hi @rogermparent 👋
For some reason this new autolink is not being picked up in https://dvc-landing-2-0-pipelin-xkejno.herokuapp.com/doc/user-guide/project-structure.
It works everywhere in https://dvc-landing-2-0-pipelin-xkejno.herokuapp.com/doc/command-reference/add and https://dvc-landing-2-0-pipelin-xkejno.herokuapp.com/doc/command-reference/check-ignore.
I noticed that if the bullet doesn't start with `.dvcignore` then it works. But that's not a problem for the previous bullets which start with `dvc.yaml` and `.dvc` 🤷
There was a problem hiding this comment.
Looks like it's being picked up to me. Maybe it was a cache issue?
There was a problem hiding this comment.
It's still happening on my local even after rm -rf .cache/ but I see it's OK in the review app now 🤷
UPDATE: Extracted this to #2125.
|
PR again addressed to much stuff at once |
|
Yeah sorry, #2098 was a significant change that required all these link updates. And while reviewing those, better options started to emerge (like the auto-links). I didn't plan all the check-boxes in advance, just added them as they came. |
|
@jorgeorpinel 👍 but let's try to this as 4 PRs please :) it's very hard to review this. |
extracted to #2124 per #2120 (comment)
extracted per #2120 (comment)
extracted to #2124 per #2120 (comment)
…ge (#2124) * glossary: finish DVC file tooltips extracted from e8b56f0 * term: multi-stages -> `foreach` stages extracted per #2120 (comment)
jorgeorpinel
changed the title
Done @shcheklein. Order: #2124, this one, #2125 |
foreachin dvc.yaml (remove term "multi-stage").~~ Extracted to glossary: finish DVC file tooltips + term: multi-stage -> foreach stage #2124.dvc/to https://dvc.org/doc/user-guide/project-structure/internal-files.Review mentions ofExtracted to link: add .dvcignore autolink #2125.dvcignoreand auto-link it.