nav: clean up Studio nav + misc. updates #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
commented
Jun 4, 2022
|
p.s. @tapadipti is this is not useful now please close it and we'll circle back after the MR release. |
3 tasks
jorgeorpinel
commented
Jun 5, 2022
There was a problem hiding this comment.
@tapadipti to make your review easier if you do want to go ahead, here's a summary of the relevant changes (the Git diff looks larger than it is due to all the link updates). Thanks
|
@jorgeorpinel rebase, @tapadipti could you please review? |
|
@jorgeorpinel I tried to review this today, but it seems I'll be replacing "views" with "projects" in many places. Shall we resolve the conflicts first? Let me know if you need me to do it. |
and some link fixes and redirect fixes
jorgeorpinel
commented
Jul 18, 2022
redirects-list.json
Outdated
Comment on lines
85
to
96
| "^/doc/studio/view-settings$ /doc/studio/user-guide/projects/project-settings", | ||
| "^/doc/studio/user-guide/explore-experiments$ /doc/studio/user-guide/projects/explore-experiments", | ||
| "^/doc/studio/user-guide/visualize-experiments$ /doc/studio/user-guide/projects/visualize-experiments", | ||
| "^/doc/studio/user-guide/run-experiments$ /doc/studio/user-guide/projects/run-experiments", | ||
|
|
||
| "^/doc/studio/user-guide/views/create-view$ /doc/studio/user-guide/projects/create-project", | ||
| "^/doc/studio/user-guide/views/view-settings$ /doc/studio/user-guide/projects/project-settings", | ||
| "^/doc/studio/user-guide/views/(.*)$ /doc/studio/user-guide/projects/$1", | ||
| "^/doc/studio/overview$ /doc/studio/how-it-works", | ||
| "^/doc/studio/view-settings$ /doc/studio/user-guide/views/view-settings", | ||
| "^/doc/studio/user-guide/explore-experiments$ /doc/studio/user-guide/views/explore-experiments", | ||
| "^/doc/studio/user-guide/visualize-experiments$ /doc/studio/user-guide/views/visualize-experiments", | ||
| "^/doc/studio/user-guide/run-experiments$ /doc/studio/user-guide/views/run-experiments", | ||
| "^/doc/studio/user-guide/prepare-repositories$ /doc/studio/user-guide/prepare-your-repositories", | ||
| "^/doc/studio/user-guide/views/create-view$ /doc/studio/user-guide/projects-and-experiments/create-a-project", | ||
| "^/doc/studio/user-guide/views/view-settings$ /doc/studio/user-guide/projects-and-experiments/configure-a-project", | ||
| "^/doc/studio/user-guide/views/explore-experiments$ /doc/studio/user-guide/projects-and-experiments/explore-ml-experiments", | ||
| "^/doc/studio/user-guide/views/visualize-experiments$ /doc/studio/user-guide/projects-and-experiments/visualize-and-compare", | ||
| "^/doc/studio/user-guide/views/share-view$ /doc/studio/user-guide/projects-and-experiments/share-a-projects", | ||
| "^/doc/studio/user-guide/views(/.*)?$ /doc/studio/user-guide/projects-and-experiments$1", |
There was a problem hiding this comment.
Updated redirects (preserves previously published 301 redirects) -- also being fixed in #3772 though
There was a problem hiding this comment.
- Also need to add redirects from
projects(/.*)?$toprojects-and-experiments$1, right? In case anyone has the old URLs bookmarked. - For some reason, in my local set-up,
http://localhost:8000/doc/studio/user-guide/does not automatically openhttp://localhost:8000/doc/studio/user-guide/prepare-your-repositories. If it does for you, you can ignore this comment. If it does not, then need to figure out the issue.
There was a problem hiding this comment.
- Also need to add redirects from projects(/.*)?$ to projects-and-experiments$1, right?
They're in #3772 which we should merge first. I am hoping we can remove those intermediate redirects though, as explained in #3772 (review) (will add change here once that PR is merged).
- in my local set-up, http://localhost:8000/doc/studio/user-guide/ does not automatically open...
Probably a caching issue (try clearing the site data). You can try it here: https://dvc-org-nav-studio-schwvjr3pxx.herokuapp.com/doc/studio/user-guide : Gatsby does a 307 redirect. On the nav, User Guide is directly linked to /prepare-your-repositories .
|
@tapadipti I fixed the conflicts. Due to the merge complexity some files are not recognized as moved by Git, but you can check the new redirects to see which ones are mainly renamed (some of them have H1 titles updated too). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jorgeorpinel
added a commit
that referenced
this pull request
Jul 19, 2022
* redirects: reinstate previous studio paths, fix others * redirects: make studio UG project links 302 due to #3621 * Update redirects-list.json * Update redirects-list.json
jorgeorpinel
removed
the
⌛ status: wait-core-merge
|
@jorgeorpinel Shall we merge this? It says there are conflicts to be resolved. |
jorgeorpinel
commented
Jul 25, 2022
Co-authored-by: Restyled.io <[email protected]>
jorgeorpinel
commented
Jul 25, 2022
jorgeorpinel
commented
Jul 25, 2022
|
OK I double checked all the redirects on the review app and it looks good. All the content changes too. Merging! |
tapadipti
added a commit
that referenced
this pull request
Jul 26, 2022
* nav: clean up and rename files + remove UG index * studio: misc. edits * studio: redirects per sidebar changes * nav: viz exps (Studio UG) * links: changes studio URLs * studio: remove how-it-works info from overview * Update content/docs/studio/user-guide/prepare-your-repositories.md * Update content/docs/studio/get-started.md Co-authored-by: tapadipti <[email protected]> * Update content/docs/studio/get-started.md Co-authored-by: tapadipti <[email protected]> * guide: better md ref link per #3621 (comment) * Restyled by prettier (#3775) Co-authored-by: Restyled.io <[email protected]> * guide: better titles for Change Team Plan and Size * guide: GH App title * guide: Connect GL Server title * Update content/docs/studio/user-guide/billing-and-payment.md * Restyled by prettier (#3777) Co-authored-by: Restyled.io <[email protected]> * Draft of Model Registry docs * Deleted package-lock.json which was committed by mistake * Further work on MR docs * Removed unnecessary gifs * Further work on MR docs * Further work on MR docs * Further work on MR docs * Studio MR docs continued * Apply suggestions from code review Co-authored-by: Jorge Orpinel <[email protected]> Co-authored-by: Jelle <[email protected]> * Applied PR review suggestions * Applied PR review comments * Applied PR review comments * Applied PR review comments * Applied PR review comments * Applied PR review comments * Applied PR review comments * Apply PR review comments * Change promote to assign stage * Small fixes to MR docs * Small fixes to MR docs * Small fixes to MR docs * Update urls of tutorial videos * Replaced the alert in the header to announce model registry release * Improved troubleshooting section * Update content/docs/studio/user-guide/model-registry/add-a-model.md Co-authored-by: Jelle <[email protected]> * Lint fix * Removed TODOs * Revert unrelated changes (wrong merge) * Other small fixes * Update content/docs/studio/user-guide/prepare-your-repositories.md * Update content/docs/sidebar.json * Restyled by prettier (#3807) Co-authored-by: Restyled.io <[email protected]> * Apply suggestions from code review * Restyled by prettier (#3808) Co-authored-by: Restyled.io <[email protected]> * Correct MR video links Co-authored-by: Jorge Orpinel Perez <[email protected]> Co-authored-by: Jorge Orpinel <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Jelle <[email protected]>
jorgeorpinel
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for large changes for MR feature
In review app: https://dvc-org-nav-studio-hv40outbutj.herokuapp.com/doc/studio