😍 ir_attachment_s3: complete rewrite

- Take away "ir.attachment.resized" model (it is in web_image_cache now) - Module is working with S3 files like binary files, but also stores url - Add abitlity to upload existing attachments from shell for more interactivity - Use virtual-hosted style addressing model (Reference: https://forums.aws.amazon.com/ann.jspa?annID=6776)
itpp-labs · Jul 23, 2020 · fa47493 · fa47493
1 parent 91cb525
commit fa47493
Show file tree

Hide file tree

Showing 13 changed files with 164 additions and 538 deletions.
diff --git a/.isort.cfg b/.isort.cfg
@@ -9,4 +9,4 @@ line_length=88
 known_odoo=odoo
 known_odoo_addons=odoo.addons
 sections=FUTURE,STDLIB,THIRDPARTY,ODOO,ODOO_ADDONS,FIRSTPARTY,LOCALFOLDER
-known_third_party=bs4,dateutil,html2text,jinja2,psycopg2,requests,requests_mock,werkzeug
+known_third_party=boto3,bs4,dateutil,html2text,jinja2,psycopg2,requests,requests_mock,werkzeug
diff --git a/ir_attachment_s3/__init__.py b/ir_attachment_s3/__init__.py
@@ -1,2 +1 @@
 from . import models
-from . import controllers
diff --git a/ir_attachment_s3/__manifest__.py b/ir_attachment_s3/__manifest__.py
@@ -3,7 +3,7 @@
     "summary": """Upload attachments on Amazon S3""",
     "category": "Tools",
     "images": [],
-    "version": "13.0.1.2.2",
+    "version": "13.0.2.0.0",
     "application": False,
     "author": "IT-Projects LLC, Ildar Nasyrov",
     "website": "https://it-projects.info",
@@ -12,11 +12,7 @@
     "currency": "EUR",
     "depends": ["base_setup", "ir_attachment_url"],
     "external_dependencies": {"python": ["boto3"], "bin": []},
-    "data": [
-        "data/ir_attachment_s3_data.xml",
-        "security/ir.model.access.csv",
-        "views/res_config_settings_views.xml",
-    ],
+    "data": ["data/ir_attachment_s3_data.xml", "views/res_config_settings_views.xml"],
     "qweb": [],
     "demo": [],
     "post_load": None,

diff --git a/ir_attachment_s3/controllers/__init__.py b/ir_attachment_s3/controllers/__init__.py
diff --git a/ir_attachment_s3/controllers/main.py b/ir_attachment_s3/controllers/main.py
diff --git a/ir_attachment_s3/doc/changelog.rst b/ir_attachment_s3/doc/changelog.rst
@@ -1,3 +1,10 @@
+`2.0.0`
+-------
+- **Improvement:** "ir.attachment.resized" model is moved to "web_image_cache" module
+- **Improvement:** "Upload existing data" functionality is now also available via shell by running env["ir.attachment"].force_storage_s3()
+- **Improvement:** Module is working with S3 files like binary files, but also stores url
+- **Improvement:** Using virtual-hosted style addressing model instead of path-style
+
 `1.2.2`
 -------
 

diff --git a/ir_attachment_s3/doc/index.rst b/ir_attachment_s3/doc/index.rst
@@ -93,7 +93,12 @@ In this case you should also install ``ir_attachment_url`` module to be able to
 Upload existing attachments
 ---------------------------
 
-* To upload existing attachments go to the ``Settings >> Technical >> Database Structure >> S3 Settings`` menu and click on the ``[Upload existing attachments]`` button there
+* There are 2 ways to upload existing attachments:
+  1. Open odoo shell and run `env["ir.attachment"].force_storage_s3()`
+  2. Go to the ``Settings >> Technical >> Database Structure >> S3 Settings`` menu and click on the ``[Upload existing attachments]`` button there
+
+  It is recommended to upload attachments via shell, because upload progress is visible in this method.
+
 * To add link of existing S3 bucket object to binary fields of existing odoo records:
 
   * Take ``Link`` urls from Amazon. If you open ``Overview`` of the object on Amazon you should see it at the bottom of the page