test(UserAuthenticationObserverServiceTest): attempt to fix test flakiness #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iness
When running this particular test inside a GitHub workflow, for some
reason, sending the interrupt signal can take some time to be received
by the Worker thread, so the LinkedBlockingQueue poll is not stopped and
new tasks can still be "infiltrated", or, maybe the latter itself takes
time to acquire a new ReentrantLock and enter the waiting state.
Luckily, we have the mReleased flag, which we can use to further prevent
new tasks from being added to the queue when Worker has been explicitly
stopped.
java.lang.AssertionError:
Expected: is <3>
but: was <4>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
at com.github.iusmac.sevensim.UserAuthenticationObserverServiceTest$TaskRunningLifecycle.test_onStartCommand_NoNewTasksShouldBeAcceptedAfterDestroyed(UserAuthenticationObserverServiceTest.java:365)
Signed-off-by: iusmac <[email protected]>
iusmac
deleted the
hotfix/UserAuthenticationObserverServiceTest-attempt-to-address-test-flakiness
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this particular test inside a GitHub workflow, for some reason, sending the interrupt signal can take some time to be received by the Worker thread, so the LinkedBlockingQueue poll is not stopped and new tasks can still be "infiltrated", or, maybe the latter itself takes time to acquire a new ReentrantLock and enter the waiting state. Luckily, we have the mReleased flag, which we can use to further prevent new tasks from being added to the queue when Worker has been explicitly stopped.