-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form storybook #35
Conversation
78a89ad
to
4a6e488
Compare
67a58a7
to
6242b31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on typing but overall looks great! Seems like formik-antd
is a pretty clean integration between ant form controls and formik
6242b31
to
1765159
Compare
Introduced the `formik-antd` library to enhance form handling and validation within the application. This change streamlines the integration of Ant Design components with Formik, offering a more robust form-building experience. Adjustments to error color definitions improve visual feedback for form errors, aligning with user expectations for clarity during form submissions. Additionally, updated dependent packages to maintain compatibility and optimize performance. References: N/A
1765159
to
43ae3df
Compare
<Select {...args} /> | ||
</Form> | ||
</Formik> | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we wrapping the select component in formik forms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnoha that's how formik-antd wrapper components are supposed to be used 🤷.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in general, any input anywhere should be used within a form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnoha sort of — If we need an input outside of the context of a form, that'll be a fork in the road we can decide on what the component(s) should look like. Granted, this wouldn't be an issue if AntD was implemented solo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also always export a non-formik-antd
<Select />
component too! But yeah it depends on the use case. Right now I don't think we're planning on using any form controls outside of the context of a form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicee lookin good!
This PR integrates formik with antd for enhanced form handling, validation, error handling visuals.