Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MKT-628: Create Providers table (Marketability) #75

Merged
merged 1 commit into from
Jan 13, 2025
Merged

MKT-628: Create Providers table (Marketability) #75

merged 1 commit into from
Jan 13, 2025

Conversation

avegancafe
Copy link
Contributor

@avegancafe avegancafe commented Jan 13, 2025 •
edited
Loading

Jira link

I disabled the padding in the example in storybook because it is probably common to need to disable the padding in a popover that uses this header, kinda a toss-up if I were to add it

image image

@avegancafe avegancafe self-assigned this Jan 13, 2025
@avegancafe avegancafe force-pushed the kyle/mkt-628-create-providers-table-marketability branch from c872728 to 2bbfd67 Compare January 13, 2025 16:27
@avegancafe avegancafe marked this pull request as ready for review January 13, 2025 16:28
@avegancafe avegancafe force-pushed the kyle/mkt-628-create-providers-table-marketability branch 7 times, most recently from c96bd82 to c5e0cf3 Compare January 13, 2025 17:31
@avegancafe avegancafe requested a review from gnoha January 13, 2025 17:33
@avegancafe avegancafe force-pushed the kyle/mkt-628-create-providers-table-marketability branch 4 times, most recently from 59e4382 to d5bdb7d Compare January 13, 2025 18:09
@avegancafe avegancafe force-pushed the kyle/mkt-628-create-providers-table-marketability branch from d5bdb7d to cde3538 Compare January 13, 2025 18:10
gnoha
gnoha approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@gnoha gnoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I'm suprised that AntD doesn't have a prop to turn off padding for stuff like this. I guess they want you to do a global design token update

@avegancafe
Copy link
Contributor Author

Yeah so odd! I didn't see it listed in their props or design tokens documentation for this component, but not sure of a better way to do this https://ant.design/components/popover#design-token

@avegancafe avegancafe merged commit 300c577 into main Jan 13, 2025
2 checks passed
@avegancafe avegancafe deleted the kyle/mkt-628-create-providers-table-marketability branch January 13, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoha gnoha gnoha approved these changes

Assignees

@avegancafe avegancafe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avegancafe @gnoha