Setup detekt lint checks

HeaderTestModule/build.gradle.kts

@@ -5,12 +5,33 @@ plugins {
     id("com.android.library")
     id("com.chromaticnoise.multiplatform-swiftpackage") version "2.0.3"
     id("kotlin-android-extensions")
+//    id("io.gitlab.arturbosch.detekt") version "1.17.1"
     jacoco
+
 }
 
 version = "0.0.1"
 group = "com.unidays.headertestmodule"
 
+//detekt {
+//    buildUponDefaultConfig = true // preconfigure defaults
+//    allRules = false // activate all available (even unstable) rules.
+//    input = files("src/commonMain/kotlin")
+//    autoCorrect = false
+//
+//    reports {
+//        html.enabled = true
+//        xml.enabled = true
+//        txt.enabled = true
+//        sarif.enabled = true
+//    }
+//}
+//
+//tasks.withType<io.gitlab.arturbosch.detekt.Detekt>().configureEach {
+//    // Target version of the generated JVM bytecode. It is used for type resolution.
+//    jvmTarget = "1.8"
+//}
+
 jacoco {
     toolVersion = "0.8.6"
 }

HeaderTestModule/src/commonMain/kotlin/com/unidays/headertestmodule/HeaderBuilder.kt

@@ -12,4 +12,4 @@ class HeaderBuilder {
         const val TEST_HEADER_ID = 1
         const val SOME_OTHER_HEADER = "Some other shit"
     }
-}
+}

KMPExampleModule/build.gradle.kts

@@ -5,12 +5,31 @@ plugins {
     id("com.android.library")
     id("com.chromaticnoise.multiplatform-swiftpackage") version "2.0.3"
     id("kotlin-android-extensions")
+    id("io.gitlab.arturbosch.detekt") version "1.15.0"
     jacoco
 }
 
 version = "0.0.1"
 group = "com.example.kmpexamplemodule"
 
+detekt {
+    buildUponDefaultConfig = true // preconfigure defaults
+    input = files("src/commonMain/kotlin")
+    autoCorrect = false
+
+    reports {
+        html.enabled = true
+        xml.enabled = true
+        txt.enabled = true
+        sarif.enabled = true
+    }
+}
+
+tasks.withType<io.gitlab.arturbosch.detekt.Detekt>().configureEach {
+    // Target version of the generated JVM bytecode. It is used for type resolution.
+    jvmTarget = "1.8"
+}
+
 jacoco {
     toolVersion = "0.8.6"
 }

KMPExampleModule/src/androidMain/kotlin/com/example/kmpexamplemodule/Platform.kt

@@ -1,5 +1,5 @@
 package com.example.kmpexamplemodule
 
 actual class Platform actual constructor() {
-    actual val platform: String = "Android ${android.os.Build.VERSION.SDK_INT}"
+    actual val name: String = "Android ${android.os.Build.VERSION.SDK_INT}"
 }

KMPExampleModule/src/androidTest/kotlin/com/example/kmpexamplemodule/androidTest.kt

@@ -7,6 +7,6 @@ class AndroidGreetingTest {
 
     @Test
     fun testExample() {
-        assertTrue("Check Android is mentioned", Greeting().greeting().contains("Android"))
+        assertTrue("Check Android is mentioned", Greeting().build().contains("Android"))
     }
 }

KMPExampleModule/src/commonMain/kotlin/com/example/kmpexamplemodule/Greeting.kt

@@ -1,7 +1,7 @@
 package com.example.kmpexamplemodule
 
 class Greeting {
-    fun greeting(): String {
-        return "Hello, ${Platform().platform}!"
+    fun build(): String {
+        return "Hello, ${Platform().name}!"
     }
-}
+}

KMPExampleModule/src/commonMain/kotlin/com/example/kmpexamplemodule/Platform.kt

@@ -1,5 +1,8 @@
 package com.example.kmpexamplemodule
 
+/* we need to suppress this as the expect / actual keywords do not work without an empty constructor.
+*  those key words are still in beta so this should fix itself eventually */
+@Suppress("EmptyDefaultConstructor")
 expect class Platform() {
-    val platform: String
-}
+    val name: String
+}

KMPExampleModule/src/commonTest/kotlin/com/example/kmpexamplemodule/commonTest.kt

@@ -7,6 +7,6 @@ class CommonGreetingTest {
 
     @Test
     fun testExample() {
-        assertTrue(Greeting().greeting().contains("Hello"), "Check 'Hello' is mentioned")
+        assertTrue(Greeting().build().contains("Hello"), "Check 'Hello' is mentioned")
     }
 }

KMPExampleModule/src/iosMain/kotlin/com/example/kmpexamplemodule/Platform.kt

@@ -3,5 +3,5 @@ package com.example.kmpexamplemodule
 import platform.UIKit.UIDevice
 
 actual class Platform actual constructor() {
-    actual val platform: String = UIDevice.currentDevice.systemName() + " " + UIDevice.currentDevice.systemVersion
+    actual val name: String = UIDevice.currentDevice.systemName() + " " + UIDevice.currentDevice.systemVersion
 }

KMPExampleModule/src/iosTest/kotlin/com/example/kmpexamplemodule/iosTest.kt

@@ -7,6 +7,6 @@ class IosGreetingTest {
 
     @Test
     fun testExample() {
-        assertTrue(Greeting().greeting().contains("iOS"), "Check iOS is mentioned")
+        assertTrue(Greeting().build().contains("iOS"), "Check iOS is mentioned")
     }
 }

codemagic.yaml

@@ -15,6 +15,12 @@ workflows:
         - &install_java_15
           name: Install Java 15.0.2
           script: ./codeMagicScripts/installJava15.sh
+        - &run_static_analysis
+          name: Run Static Analysis
+          script: |
+            source ~/.bash_profile
+            export JAVA_HOME=$JAVA_LOCATION
+            ./gradlew -Dorg.gradle.java.home=$JAVA_LOCATION build KMPExampleModule:detekt
         - &run_unit_tests
           name: Run Unit Tests
           script: |
@@ -57,6 +63,7 @@ workflows:
             source: true
       scripts:
         - *install_java_15
+        - *run_static_analysis
         - *run_unit_tests
         - *verify_tests_coverage
       artifacts: