Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation workflow #40

Merged
merged 20 commits into from
Jun 29, 2024
Merged

Fix validation workflow #40

merged 20 commits into from
Jun 29, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 29, 2024

Which problem is this PR solving?

  • Workflow wasn't running on PRs because it had the wrong file name for the workflow

Description of the changes

  • Fix the name
  • Allow pushing to a local registry when running from PR
  • Use image from local registry to verify protobuf builds in jaeger and jaeger-idl repos

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title Fix file name in workflow filter Fix validation workflow Jun 29, 2024
@yurishkuro yurishkuro merged commit 20742e7 into main Jun 29, 2024
2 checks passed
@yurishkuro yurishkuro deleted the add-validation2 branch June 29, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant