Skip to content

Commit

Permalink
Fix undefined variable
Browse files Browse the repository at this point in the history
On the method historicalTrades variable $fromTradeId is undefined.
Change $fromTradeId to $tradeId
  • Loading branch information
thebusted authored and dmzoneill committed May 5, 2021
1 parent 4f968eb commit dc8e6fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion php-binance-api.php
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ public function historicalTrades(string $symbol, int $limit = 500, int $tradeId
"symbol" => $symbol,
"limit" => $limit,
];
if ($fromTradeId > 0) {
if ($tradeId > 0) {
$parameters["fromId"] = $tradeId;
} else {
// if there is no tradeId given, we can use v3/trades, weight is 1 and not 5
Expand Down

0 comments on commit dc8e6fd

Please sign in to comment.