Development (#48)

* improvements for static list * Time filter * remove github assets * Updated readme * New option: Hidden Stock * Update README.md Co-authored-by: Jan Litzenburger <[email protected]>
jalibu · Aug 13, 2022 · 1cc458d · 1cc458d
1 parent 7a828b7
commit 1cc458d
Show file tree

Hide file tree

Showing 14 changed files with 116 additions and 111 deletions.
diff --git a/MMM-Jast.js b/MMM-Jast.js
diff --git a/README.md b/README.md
@@ -68,6 +68,7 @@ Static
    		showChangePercent: true,
    		showChangeValue: false,
    		showChangeValueCurrency: false,
+   		showHiddenStocks: false,
    		showLastUpdate: false,
    		showPortfolioValue: false,
    		showPortfolioGrowthPercent: false,
@@ -78,7 +79,7 @@ Static
    		stocks: [
    			{ name: "BASF", symbol: "BAS.DE", quantity: 10 },
    			{ name: "SAP", symbol: "SAP.DE", quantity: 15 },
-   			{ name: "Henkel", symbol: "HEN3.DE" },
+   			{ name: "Henkel", symbol: "HEN3.DE", hidden: true },
    			{ name: "Alibaba", symbol: "BABA"}
    		]
    	}
@@ -103,6 +104,7 @@ Static
 | `showChangePercent`           | Show stocks change against last close in percent. <br><br>**Type:** `Boolean`<br> **Default value:** `true`                                                                          |
 | `showChangeValue`             | Show stocks change against last close in absolute value. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                  |
 | `showChangeValueCurrency`     | Show currency for change value. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                                          |
+| `showHiddenStocks`              | Ignore the hidden property for each stock. This can be useful when you use the same set of stocks with multiple module instances. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                                           |
 | `showLastUpdate`              | Show when the data was updated. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                                           |
 | `showPortfolioGrowth`         | Show portfolio value growth summary. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                                     |
 | `showPortfolioGrowthPercent`  | Show portfolio value growth summary in percent. <br><br>**Type:** `Boolean`<br> **Default value:** `false`                                                                          |
@@ -118,6 +120,7 @@ Static
 | ---------- | ---------------------------------------------------------------------------------------------------------- |
 | `symbol`   | Stock's symbol/key <br><br>**Type:** `String` <br> **Example value:** `"SAP.DE"`                           |
 | `name`     | Optional: Stock's display name <br><br>**Type:** `String` <br> **Example value:** `"SAP"`                  |
+| `hidden`     | Optional: If set to true, this stock is not shown in the ticker but it is still used for portfolio calculation. <br><br>**Type:** `Boolean` <br> **Default value:** `false`         |
 | `quantity` | Optional: To calculate portfolio value and growth <br><br>**Type:** `Number` <br> **Example value:** `500` |
 
 ### Where the hack do I get the symbol for my favorite stocks?!

diff --git a/node_helper.js b/node_helper.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "mmm-jast",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "A minimalistic stock ticker based on Yahoo's finance API for the MagicMirror² platform.",
   "main": "MMM-Jast.js",
   "repository": {

diff --git a/src/backend/Backend.ts b/src/backend/Backend.ts
@@ -18,7 +18,8 @@ module.exports = NodeHelper.create({
   },
 
   async socketNotificationReceived(notification, payload) {
-    if (notification === 'JAST_STOCKS_REQUEST') {
+    if (notification.includes('JAST_STOCKS_REQUEST')) {
+      const identifier = notification.substring('JAST_STOCKS_REQUEST'.length + 1)
       let stocks = await JastBackendUtils.requestStocks(payload)
 
       stocks = stocks.filter((stock) =>
@@ -39,7 +40,7 @@ module.exports = NodeHelper.create({
         stocks
       }
 
-      this.sendSocketNotification('JAST_STOCKS_RESPONSE', response)
+      this.sendSocketNotification(`JAST_STOCKS_RESPONSE-${identifier}`, response)
     } else {
       Log.warn(`${notification} is invalid notification`)
     }

diff --git a/src/backend/JastBackendUtils.ts b/src/backend/JastBackendUtils.ts
@@ -22,7 +22,8 @@ export default class JastBackendUtils {
         const meta = {
           symbol: config.stocks[index].symbol,
           name: config.stocks[index].name,
-          quantity: config.stocks[index].quantity
+          quantity: config.stocks[index].quantity,
+          hidden: config.stocks[index].hidden
         }
         // Manually convert GBp to GBP
         if (response.price.currency === 'GBp') {