rmAnova: improve singularity handling #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviselker
force-pushed
the
bugfix/rmanova-sphericity
branch
from
85c6616 to
8d3f431
Compare
When a singularity error occurs, there is now a main "warning message" that describes what could be the problem and ways to mitigate this, and for each row that is affected a short footnote is added. Moreover, this commit contains a major refactor of the code to make handling of all sphericity related results much easier.
raviselker
force-pushed
the
bugfix/rmanova-sphericity
branch
from
8d3f431 to
a704c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a singularity error occurs, there is now a main "warning message" that describes what could be the problem and ways to mitigate this, and for each row that is affected a short footnote is added.
Moreover, this commit contains a major refactor of the code to make handling of all sphericity related results much easier.
I decided the use the notice system instead of creating an Html object for now, so that we can have a think about how to do this properly (also taking into account a11y). It should be easy to make this change once this functionality is added.