fix duplicate key deletion when forget called #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
reviewed
Sep 3, 2024
singleflight_test.go
Outdated
| secondCh := make(chan struct{}) | ||
| secondRunning := make(chan struct{}) | ||
| go func() { | ||
| g.Do(context.Background(), "key", func(ctx context.Context) (i int, e error) { |
There was a problem hiding this comment.
Could you explicitly check or ignore the error from g.Do?
janos
approved these changes
Sep 3, 2024
|
hey @janos thanks for merging, |
|
Ah yes, version 0.4.3 has been released just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @janos,
I believe your implementation of singleflight is affected by the issue described here:
golang/go#31420.
This issue specifically impacts your implementation because a thread can call
Forget()after its own context has expired.I implemented the solution found in this CL:
https://go-review.googlesource.com/c/sync/+/171897.
All existing tests pass successfully, and I also added the test from the CL to ensure that the new behavior is consistent with Google’s implementation.
Note: Before applying the fix, the TestForgetMisbehaving test failed.