Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually invoke init in components stuck in "first" #1094

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Actually invoke init in components stuck in "first" #1094

merged 1 commit into from
Jul 10, 2024

Conversation

rpiaggio
Copy link
Collaborator

Components that only used the useEffect family of hooks didn't invoke the hooks.

cquiroz
cquiroz approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpiaggio rpiaggio merged commit c6e3bbf into master Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpiaggio @cquiroz