Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create python-package.yml #208

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create python-package.yml #208

wants to merge 7 commits into from

Conversation

jason-neal
Copy link
Owner

No description provided.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces a GitHub Actions workflow aimed at automating the process of installing Python dependencies, running tests, and linting code across multiple Python versions. It is designed to trigger on push and pull request events to the master branch. The workflow includes steps for setting up Python environments, installing dependencies, preparing data, linting with flake8, testing with pytest, checking documentation, and reporting coverage.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that all external scripts and data files referenced in the workflow (e.g., download_eniric_data.sh) are available in the repository and have the correct permissions set.
  • Consider specifying exact versions for Python packages installed during the workflow to avoid potential inconsistencies due to package updates.
  • Review and correct any typos or inaccuracies in the workflow file to prevent potential execution failures. For example, the typo in the command to install project dependencies should be corrected to match the intended package name.
  • It might be beneficial to extend the workflow to include additional Python versions or to cover more branches, depending on the project's needs and compatibility requirements.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
- name: Install eneric
run: |
pip install -e .[dev,test,docs,ci]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (llm): The command to install 'eneric' seems to have a typo. It's likely meant to be 'eniric', as referenced in later steps. This typo could lead to a failure in the workflow execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant