More readable URL's and private profile name visibility fix #100
Conversation
| @@ -15,7 +15,7 @@ public static DisplayAuthor fromUserForUser( | |||
| ) { | |||
| switch(sourceUser.getProfileVisibility()) { | |||
| case PRIVATE: | |||
| if (sourceUser == requestingUser) { | |||
| if (sourceUser.equals(requestingUser)) { | |||
There was a problem hiding this comment.
Thank you for catching and fixing this! And thank you for calling it out in a separate commit.
| ); | ||
| } | ||
|
|
||
| private static DisplayAuthor useInternal(User user) { | ||
| String slug = slugify.slugify(user.getInternalName()); |
There was a problem hiding this comment.
I think we had talked about using the public name throughout for profile slugs, regardless of whether or not the viewer is logged in... or at least, that's what I wrote down after our discussion! I'm fine with going with this instead, but I just wanted to double-check that it was intentional?
There was a problem hiding this comment.
Yes, this was intentional. We decided to use internal info for a user's pages when they are logged in. So I'm good with this, I guess we just need a confirmation from @EL246. :)
|
Ah sorry, it looks like #94 introduced some changes that conflict with changes in this PR; the conflicts will need to be resolved before this can be merged. Please rebase onto master and fix the merge conflicts git complains about. Let me know if you'd like any help resolving them, or if you'd like me to just handle it! |
Issue jasonaowen#12 More readable URL's Co-authored by: EL246 <[email protected]>
… in project listings when they are logged in. resolves issue jasonaowen#97 Authors shown as "Anonymous" on the project list page when full author name should be visible Co-authored-by: j9peters <[email protected]>
issue jasonaowen#12 More readable URLS Co-authored-by: j9peters <[email protected]>
j9peters
force-pushed
the
more-readable-user-urls
branch
from
69ddb77 to
90dc82c
Compare
|
Merge conflicts resolved! |
Include slugified user name in user URL's
Links to projects in project lists now contain project slugs
A user with private profile visibility can now view their own name in project listings when they are logged in
Issue #12 More readable URLs
Resolves issue #97 Authors shown as "Anonymous" on the project list page when full author name should be visible
Co-authored-by: EL246 [email protected]