Full rewrite of the crate #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally wrote `Rdsp` instead of `Rsdp`, in multiple places. Oops!
Additionally, export it as a `Duration`
`new` no longer takes a parameter.
`InternalModules` no longer exists. Instead, a simple slice is used.
Currently, it's only stable on 1.77.
Clippy already builds
|
Alright, everything should be done now. Merge at your earliest convenience. |
48cf
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Please make up your mind about the spacing in between items and whether the doc comments should be put before or after attributes. The spacing is inconsistent with multiple items having no spacing in between and some doc comments being put between the attributes and the item they belong to
|
Yeah sorry about that, I thought I caught all of those. I'll do a regex search I guess. |
48cf
approved these changes
Jan 27, 2024
A user can attempt the conversion themself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate is not in great shape. It has 4 unresolved issues, all of which are UB. It also does not correctly support platform-specific features. The API is confusing, and leaves much to be desired.
In this rewrite, I took into account my own struggles with the crate, as well as comments from other users. The history of this crate is rough, but I hope we can turn it around starting now.
I'll note that my changes are heavily opinionated (rustfmt, clippy with
-D warnings, etc.), so feel free to bring up your concerns if you have any. I also have not implemented any tests, but I figure we can implement tests through the barebones project.This fixes #12 and fixes #14, and indirectly fixes #13 and indirectly fixes #16 by way of removing them.
Edit: GitHub doesn't understand "and"