Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #31 (null edid) #32

Merged
merged 2 commits into from
Jun 8, 2024
Merged

fix #31 (null edid) #32

merged 2 commits into from
Jun 8, 2024

Conversation

jasondyoungberg
Copy link
Owner

Return an option incase the edid is null.

fixes #31

@lylythechosenone lylythechosenone self-requested a review June 8, 2024 00:21
@lylythechosenone
Copy link
Collaborator

While this does technically work, I think a better approach would be to just use Option<NonNull<u8>> as the field type. I'm going to add that in.

@lylythechosenone
Copy link
Collaborator

That should do it. CI failure is another thing.

@lylythechosenone lylythechosenone merged commit 391ed0f into jasondyoungberg:master Jun 8, 2024
1 check failed
@lylythechosenone lylythechosenone removed their request for review June 8, 2024 00:54
@lylythechosenone lylythechosenone mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panics when edid is null
2 participants
@jasondyoungberg @lylythechosenone