Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limine protocol #34

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Update limine protocol #34

merged 3 commits into from
Aug 21, 2024

Conversation

adavis628
Copy link
Contributor

This PR updates the library to use the most recent limine protocol revision. Specifically, it:

  • Adds FirmwareTypeRequest
  • Updates the base protocol revision
  • Updates PagingModeRequest
  • Removes FiveLevelPagingRequest, as it is no longer documented in the limine protocol
  • Updates smp::Cpu

@mintsuki
Copy link
Collaborator

error[E0432]: unresolved import `core::net`
  --> src/file.rs:10:11
   |
10 | use core::net::{Ipv4Addr, SocketAddrV4};
   |           ^^^ could not find `net` in `core`

@lylythechosenone
Copy link
Collaborator

@mintsuki thats an us problem. Ignore it. I still have to investigate.

Copy link
Collaborator

@lylythechosenone lylythechosenone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll look through the spec just to make sure and then we can merge this 👍.

src/smp.rs Show resolved Hide resolved
@mintsuki mintsuki merged commit 7684895 into jasondyoungberg:master Aug 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants