Code review #16
Open
Code review #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reusable components
Url model and controller
Add shorten url functionality
Handle shorten link
Handle pin and unpin url
UI improvements
Error handling
Improve table and input ui
kabir4691
reviewed
Mar 1, 2021
| before_action :find_url, only: %i[show update] | ||
|
|
||
| def index | ||
| urls = Url.all.order("pinned DESC, updated_at DESC") |
There was a problem hiding this comment.
Create a scope in Url model and use it
There was a problem hiding this comment.
kabir4691
reviewed
Mar 1, 2021
|
|
||
| def create | ||
| url = Url.new(url_params) | ||
| url.slug = generate_slug |
There was a problem hiding this comment.
Controller's only job is to receive a request, fetch data from the db and send it to view.
All other business logic should go in the model, like generate_slug
kabir4691
reviewed
Mar 1, 2021
| @@ -1,4 +1,9 @@ | |||
| Rails.application.routes.draw do | |||
|
|
|||
| resources :urls, only: %i[index create] | |||
| get '/:slug' => "urls#show" | |||
There was a problem hiding this comment.
Make routes resourceful always. In this example, use slugs/:slug instead or /:slug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.