fix rotation value - modulo computation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamespo
approved these changes
Sep 20, 2020
|
Yep - this confused me for a few minutes as couldn't get my 'tree' to display with the correct orientation. Changed to % 4 and all good (as in the commit above). |
|
@jayniz Could we merge this? Note that there is another (conflicted) pull request open with the same fix. |
|
Totally missed the PRs, sorry folks ❤️ |
|
Thanks, @jayniz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #8
Function arg to
rotation(int)can be in range [0, 360].Internally, _rotation is stored as int with range [0, 3].
Thus, modulo argument needs to be 4.