Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Fix: Use charset provided by web server instead of utf-8 #153

Conversation

DerDreschner
Copy link
Contributor

When downloading a calendar file from a web server, it can happen the charset isn't utf-8 (like in #104). We should use that charset for decoding the downloaded content instead of using UTF-8.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (4d29ced) to head (abebd44).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
icalevents/icaldownload.py 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   91.82%   91.02%   -0.80%     
==========================================
  Files           4        4              
  Lines         379      379              
  Branches      100      101       +1     
==========================================
- Hits          348      345       -3     
- Misses         13       15       +2     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant