Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example about ingress with cert-manager annotation #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

claudio4j
Copy link

Remove unecessary dockerfiles

@claudio4j
Copy link
Author

@johnpoth for review. I can add the same example to the CSB project this one is ok.

@johnpoth
Copy link
Contributor

Hi @claudio4j thanks this looks great!

I wonder if this should be integrated into the example and not be in a separate section ? Also, since this is for OCP shouldn't we use Routes instead of Ingress ? Thanks for removing those docker files; should we remove them for the other examples too ? Cheers!

@claudio4j
Copy link
Author

claudio4j commented Jan 23, 2025

if this should be integrated into the example and not be in a separate section ?

Do you mean to use the ingress as the API endpoint for the server and not the route ?

shouldn't we use Routes instead of Ingress

I wanted to highlight the Ingress usage because cert-manager annotations only works in ingress resources, not routes.

should we remove them for the other examples too

sure, I will do it when working in the csb example.

@johnpoth
Copy link
Contributor

Ah yeah your right it seems it's in only supported in Technology Preview https://docs.openshift.com/container-platform/4.17/networking/routes/secured-routes.html#nw-ingress-route-secret-load-external-cert_secured-routes maybe sometime in the future then ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants