feat: add TryLogin(string, SecureString) methods #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelgwelch
force-pushed
the
welch/addCredentialManagersForLinuxMacOS
branch
from
7d9b2fb to
54016ea
Compare
This commit does all the following - Add TryLogin(string, SecureString) methods so that the password can be passed as a SecureString - Added credential manager classes for Linux, macOS and Windows - macOS: KeyChain - Linux: libsecret (depends on libsecret-tools cli) - Windows: Credential Manager - Add TryLogin(string) methods. This will load the credentials based on hostname and username on all OSes. - Add support for TryLogin() on all OSes. Looks up credentials based on hostname - Create dotnet tool `metasys-secrets` which is cross platform and can be used on macOS, Linux and Windows to add credentials to the default credential manager - Added steps in CI build to test on Windows and macOS as well - Deprecate all of the TryLogin methods that take a bool for refreshToken since it wasn't doing anything and there's no reason to not refresh the token automatically. It's not a choice that should be exposesd to a user without a good reason why they would want to set it to false.
michaelgwelch
force-pushed
the
welch/addCredentialManagersForLinuxMacOS
branch
from
54016ea to
01652e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does all the following
metasys-secretswhich is cross platform and can be used on macOS, Linux and Windows to add credentials to the default credential manager