Make WAF errors fail closed by default. Add waf-fail-closed=false to override #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmoraisjr
reviewed
Oct 27, 2022
jcmoraisjr
added a commit
that referenced
this pull request
Nov 21, 2022
Revert "Merge pull request #954 from mac-chaffee/fail-closed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full issue is described here: haproxy/spoa-modsecurity#3
Note: This is a breaking change from 0.14 to 0.15
This PR changes the default behavior (that we copied from the upstream spoa-modsecurity docs) of allowing requests through if modsecurity errors out or times out. Now, only a valid response from modsecurity (
txn.modsec.code=0) will allow requests through.Users can go back to the old behavior by setting
waf-fail-closed: falsewhich would mean that e.g. a flood of requests could overload modsecurity-spoa and trigger timeouts, which would allow requests through without being scanned by modsecurity.