Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes uppercase bug; adds tests #6

Open
wants to merge 293 commits into
base: dev
Choose a base branch
from
Open

fixes uppercase bug; adds tests #6

wants to merge 293 commits into from
+5,425 −2,180

Conversation

kdmukai
Copy link

@kdmukai kdmukai commented Jan 20, 2025

Description

fixes SeedSigner#665

  • BUGFIX: parse address QR formats that may be in all caps.
  • Refactor the address QR parsing.
  • Add tests, make existing test more DRY.

This pull request is categorized as a:

  • Bug fix
  • Code refactor

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • Yes

I have tested this PR on the following platforms/os:

Jean Do added 30 commits December 1, 2022 17:04
dont translate sig-or-script-types yet
4c416c8
ok, now translate sig/script-types
4a8a04c
Merge branch 'dev' into kdmukai/initial_multilanguage
4b0dc31
postmerge bugfix on poorly resolved conflict
4df5757
i18n/l10n settings i18n/l10n-ized too
8ca3edb
Merge branch 'dev' into kdmukai/initial_multilanguage
2f18588
french l10n revisited
a4c784e
i18n/l10n iter: RemoveableMicroSd/BIP85-ChildSeeds
eab4942
working w/o halting
3d0395e
message catalog cleanup
6de246f
added en locale and translated langs
1b94005
gettext() from instance, not class
e433b50
added views for more screenshots
bf5561f
fr/es by nmhs
14174c6
exclude line-num from message catalogs
1e45c45
messages.po catalogs included
760b157
l10n by nmhs
9a4063a
access font sizes w/ getter() for i18n
9d4f469
discard-seed and seedqr-format screenshots in tests
2ff0c90
tiny effort to i18n-ize embit strings
1e283bd
i18n special keys (del,space)
79857b6
One last screen, and this exploration is hereby paused!
e13f5dc
Merge branch 'dev' into kdmukai/initial_multilanguage
fe5f0a5
updated readme
5b6961e
resolves Pillow 10 deprecation warning
0f7ea65
Merge branch 'dev' into kdmukai/initial_multilanguage
d17b21f
merge cleanup
9f07504
some locales disabled
0f44a29
i18n msgid extractions
4834a20
Merge branch 'dev' into kdmukai/initial_multilanguage
3de70c1
copy2018 and others added 27 commits December 30, 2024 17:48
@copy2018
Update README.md to fix version naming for verification step
5cf5a01 
Included the latest version in the verification instructions.
@kdmukai
add SeedAddressVerificationSuccessScreen
b5e3d4f
@kdmukai
bugfix on show_back_button
5ad4818
@kdmukai
Refactor / simplify HardwareButtons
8c902aa
@kdmukai
cleanup
9efb700
@kdmukai
Removing outdated comment
7c09dc1
@kdmukai
bugfix on edge case Compact SeedQRs
5267844
@kdmukai
Further bugfix; convert first, then check length
75ba1e0
@kdmukai
add test case
cf83ebe
@kdmukai
bugfix for method arg change
7990193
@newtonick
Merge pull request SeedSigner#657 from kdmukai/decodeqr_bytes_fix_v2
6407310 
[bugfix] `DecodeQR`: handle Compact SeedQR byte data that can be decoded to `str`
@newtonick
Merge pull request SeedSigner#658 from kdmukai/seedqr_dev_tool_update
c0a2799 
[low priority] [bugfix] Update dev tool for creating test SeedQRs
@newtonick
Merge pull request SeedSigner#651 from kdmukai/update_SeedAddressVeri…
64d63c7 
…ficationSuccess

[Screen Redesign] Light rearrangement of SeedAddressVerificationSuccess
@newtonick
Merge pull request SeedSigner#649 from copy2018/patch-1
24d688a 
Update README.md to fix version naming for verification steps
@kdmukai
swapping out print() for logging.info()
e972fc8
@newtonick
Merge pull request SeedSigner#655 from kdmukai/hardwarebutton_refactor
825a25a 
[Refactor / bugfix] Simplify `HardwareButtons`
@kdmukai
Adds missing text wrapping for "Electrum seeds"
0179a62
@kdmukai
Sync submodules to latest translations and screenshots
ab18ec1
@kdmukai
Update submodule branch reference
b4ee0e7
@kdmukai
Update translations repo pointer to latest commit
46d9a53
@easyuxd
Added input/keyboard icons (delete, space)
b4b484b
@kdmukai
Start using named variables in l10n English source strings
2fedf2d
@kdmukai
Sync submodule pointers
568534d
@newtonick
Merge pull request SeedSigner#605 from easyuxd/messaging-components
be465a3 
Messaging Components - Colors and Icons
@newtonick
Merge pull request SeedSigner#661 from kdmukai/0.8.5-rc1_fixes
cbaaaf4 
Minor 0.8.5-rc1 fixes, syncing translations and screenshots repos
@kdmukai
fixes uppercase bug; adds tests
f9534e7
@kdmukai
minor improvement after reviewing coverage
2bd3233
@kdmukai kdmukai changed the base branch from verify_bw_addy_upper to dev January 20, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kdmukai @enteropositivo @easyuxd @fedebuyito @newtonick @steven-s-martins @copy2018