fix: mise does not operate well under Git Bash on Windows

[roele]

Fixes #4011

Gave this a try but detection of msys or cygwin does not work via $OSTYPE as this is not available via env so env::var() does not return anything. Not sure how reliable my approach via MSYSTEM and PWD is though.

Another unresolved issue seems to be related to line breaks on cygwin. The .bashrc file does not source successfully until its opened and saved (without changes). Probably would require a dos2unix on cygwin, not sure why that is not an issue on msys.

$ source .bashrc
': not a valid identifiernctions
-bash: .bashrc: line 35: syntax error near unexpected token `$'\r''
'bash: .bashrc: line 35: `function __zsh_like_cd() {

[roele]

there is no -a flag for export i assume this is supposed to be declare?

[jdx]

I think it is necessary, I got it from here https://github.com/rvm/rvm/tree/master/scripts/extras/bash_zsh_support/chpwd

[jdx]

for what it's worth, I'm not sure git bash is a necessary use-case for us. There are many alternatives like shims, powershell, and wsl for windows users.

[roele]

I'm generally not a Windows user but I agree that shims and powershell seem to work well enough. Windows is a PITA anyways, in my last project Git Bash was my only option (was not allowed to use WSL or install anything else). While probably rare there might be some users restrained to such a setup.

[jdx]

right but even then shims will work. What won't work is you won't see env vars unless you wrap things in tasks but as I'm sure you've heard me explain, that's kind of how I think projects should be setup anyways since it doesn't rely on shell extensions.

mise en would be another alternative

[roele]

I noticed that when using shims in context of cygwin/mysys a .cmd suffix has to be added though.

[jdx]

isn't that already happening?

[roele]

What i mean is that i would expect for example that i can use java -version in Git Bash but instead i have to use java.cmd -version.

[jdx]

is this something that can be configured with PATHEXT? or is there a git bash equivalent for that?

[roele]

PATHEXT is a Windows environment variable and i am not aware of an equivalent in Git Bash/Cygwin. Emulating PATHEXT in Bash does also not seem to work.

export PATHEXT=.com:.exe:.bat:.cmd

if declare -f command_not_found_handle >/dev/null; then 
    eval "original_command_not_found_handle() $(declare -f command_not_found_handle|tail -n +2)"
fi
command_not_found_handle(){
    local PATHEXT_EXPANDED i
    IFS=: read -a PATHEXT_EXPANDED<<<"$PATHEXT"
    for i in "${PATHEXT_EXPANDED[@]}"; do
        if type "$1$i" &>/dev/null; then
            "$1$i" "${@:2}"
            return $?
        fi
    done
    if declare -f original_command_not_found_handle >/dev/null; then
        original_command_not_found_handle "$@"
    else
        return 127
    fi
}

While this PR makes activate work for Git Bash and Cygwin detection seems a bit hacky. I wonder if we should drop this for now. Having at least the shims work would be great though.

[roele]

The following hook might be a workaround for the shims .cmd ending issue. We might simply document this as possible workaround in the troubleshooting docs "Windows problems" section.

command_not_found_handle()
{
   cmd=$1
   shift
   args=( "$@" )

   IFS=:
   for dir in $PATH; do
      for executable in $dir/$cmd.bat $dir/$cmd.cmd $dir/$cmd.exe; do
         if [ -f "$executable" ]; then
            "$executable" "${args[@]}"
            return
         fi
      done
   done

   orig_command_not_found_handle "$cmd" "${args[@]}"
} 
if declare -f command_not_found_handle >/dev/null; then 
    eval "orig_command_not_found_handle() $(declare -f command_not_found_handle|tail -n +2)"
fi