Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct python path for venv creation in windows #4164

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

tisoft
Copy link
Contributor

@tisoft tisoft commented Jan 20, 2025

Python installations on windows do not have a bin directory. This is already taken into account in different places, but when automatically creating venvs bin is always used.

This change was my attempt to fix this as a non-rust developer with minimal code changes and reusing the existing python_path function. I had to make the python plugin public, which is probably not the way to do it. 😄

So I am open to suggestions on how to properly fix this.

#4152

@tisoft tisoft force-pushed the windows_python_venv branch from d7cf0cc to cb8ac66 Compare January 20, 2025 12:17
Copy link
Contributor

autofix-ci bot commented Jan 20, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@tisoft tisoft force-pushed the windows_python_venv branch from cb8ac66 to 89e2927 Compare January 20, 2025 12:30
@tisoft tisoft marked this pull request as ready for review January 20, 2025 14:12
@jdx jdx merged commit 5b2d795 into jdx:main Jan 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants