Make top-level serialization context accessible to custom serializers #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext object, if available, as the parent of the created serialization context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #229 where the optional serialization context is not accessible to BinarySerializationContext tree when working with an IBinarySerializable class.
I think it's a little quirky that when traversing up the SerializationContext tree there are two BinarySerializationContext nodes with the same value (the root), and now the optional context above that, but this preserves the existing behavior of the framework.
I also noticed that passing in a primitive type like a string for the optional context will not save the context into the RootValueNode, as it only looks for children objects, but that's out of scope for the issue I was facing.
I have no idea if I've solved the problem in a correct way, but it works for my use case. I'm newer to the library side of things, does changing CreateSerializationContext from private to protected virtual count as a breaking change?