Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable audio/video streaming; overhaul build #83

Merged
merged 3 commits into from
Feb 25, 2018

Conversation

lunixbochs
Copy link
Contributor

@lunixbochs lunixbochs commented Sep 6, 2017

This patchset updates to spice-gtk 0.34 as well as the latest versions of spice-protocol, virt-manager, and virt-viewer, updates all virt-manager python packages, enables audio/video streaming, patches virt-manager to default to --no-fork enabled, and fixes all homebrew/install problems I encountered. It will install and run out of the box on a fresh instance of macOS 10.12.6 Sierra just with brew install virt-manager; ./virt-manager and no python path changes required.

It will fix most or all of the following build/crash-related bugs, barring any local user python/compiler issues: #82, #81, #80, #79, #77, #76, #74, #72, #71, #68, #62, #58, #57, #56, #52, #49, #48, #45, #44, #30

It definitely fixes #78 (silently quits at launch) and fixes #5 (support for audio).


Furthermore, is there any reason this formula set hasn't been pushed to upstream Homebrew? It should qualify, and libvirt is already there. The main changes I'd seek are patching libvirt so qemu+ssh://host/system will try both the linux and osx socket paths, making askpass work, and making sure we use libjpeg-turbo.


I'm also willing to share my spice-server and qemu build/config instructions for anyone interested in having working video streaming.

@kmalinich
Copy link

@lunixbochs I'm personally very interested in your spice-server and qemu build setup.. Also, great work, this is a really tricky brew project (IMO) - I've tapped and have been using your branch for a few weeks now, it's great

@lunixbochs
Copy link
Contributor Author

lunixbochs commented Nov 1, 2017

This is my qemu build script for Ubuntu 16.04 (script should mostly execute on a bare Ubuntu 16 box - you can use lxd to make one if you need): https://bochs.info/p/nhxmhb

I've noticed some performance regressions (I think when spice doesn't have a guest driver), so I need to tweak something. Maybe libjpeg-turbo. It's encouraging if you don't have any perf issues as it means that's something I can fix in my qemu build.

@mmeyer724
Copy link

mmeyer724 commented Nov 20, 2017

For now I would recommend using lunixbochs' fork of this formula..

brew tap lunixbochs/homebrew-virt-manager
brew install virt-manager virt-viewer

@chpatton013
Copy link

@jeffreywildman Your package is unusable without this PR, which has idled for almost 5 months. Please consider merging this sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virt-manager silently quits at launch Support for audio
5 participants