enable audio/video streaming; overhaul build #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates to spice-gtk 0.34 as well as the latest versions of spice-protocol, virt-manager, and virt-viewer, updates all virt-manager python packages, enables audio/video streaming, patches virt-manager to default to
--no-fork
enabled, and fixes all homebrew/install problems I encountered. It will install and run out of the box on a fresh instance of macOS 10.12.6 Sierra just withbrew install virt-manager; ./virt-manager
and no python path changes required.It will fix most or all of the following build/crash-related bugs, barring any local user python/compiler issues: #82, #81, #80, #79, #77, #76, #74, #72, #71, #68, #62, #58, #57, #56, #52, #49, #48, #45, #44, #30
It definitely fixes #78 (silently quits at launch) and fixes #5 (support for audio).
Furthermore, is there any reason this formula set hasn't been pushed to upstream Homebrew? It should qualify, and
libvirt
is already there. The main changes I'd seek are patchinglibvirt
soqemu+ssh://host/system
will try both the linux and osx socket paths, makingaskpass
work, and making sure we use libjpeg-turbo.I'm also willing to share my spice-server and qemu build/config instructions for anyone interested in having working video streaming.