Skip to content

Commit

Permalink
Merge branch 'master' into improve-boxset-sort-options
Browse files Browse the repository at this point in the history
  • Loading branch information
jimdogx authored Jan 15, 2025
2 parents f3a6682 + d8487db commit 78f072f
Show file tree
Hide file tree
Showing 46 changed files with 3,105 additions and 607 deletions.
40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

123 changes: 123 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
name: Bug Report
description: Report a bug with the software.
labels: bug
body:
- type: checkboxes
id: before-posting
attributes:
label: "This issue respects the following points:"
description: All conditions are **required**.
options:
- label: This issue is **not** already reported on [GitHub](https://github.com/jellyfin/jellyfin-roku/issues?q=is%3Aopen+is%3Aissue) _(I've searched it)_.
required: true
- label: I agree to follow Jellyfin's [Code of Conduct](https://jellyfin.org/docs/general/community-standards.html#code-of-conduct).
required: true
- label: This report addresses only a single issue; If you encounter multiple issues, kindly create separate reports for each one.
required: true

- type: markdown
attributes:
value: |
## Software Versions
- type: input
id: jellyfin_server_version
attributes:
label: Jellyfin Server Version
placeholder: "e.g., 10.9.11 or 10.10.3"
validations:
required: true
- type: input
id: roku_version
attributes:
label: Roku Client Version
placeholder: "e.g., 2.1.8 or 2.2.5"
validations:
required: true

- type: markdown
attributes:
value: |
## Bug Information
- type: textarea
id: bug_description
attributes:
label: Bug Description
description: Provide a clear and concise description of what the bug is.
placeholder: "When playing a movie via the «Resume from» context menu, I get the error message «xyz»"
validations:
required: true
- type: textarea
id: steps_to_reproduce
attributes:
label: Steps to Reproduce
description: Provide steps to reproduce the behavior
placeholder: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. Bug occurs
validations:
required: true
- type: textarea
id: expected_behavior
attributes:
label: Expected Behavior
description: Provide a clear and concise description of what you expected to happen.
placeholder: "Describe what you expected to happen."
validations:
required: true
- type: textarea
id: logs
attributes:
label: Logs
description: Please paste any logs here.
placeholder: "Paste logs here, if available."
validations:
required: false
- type: textarea
id: screenshots
attributes:
label: Screenshots
description: If applicable, add screenshots to help explain your problem
placeholder: "Paste Screenshots here, if available."
validations:
required: false

- type: markdown
attributes:
value: |
## Connection Information
- type: dropdown
id: server_access_relativity
attributes:
label: Is the server local or remote?
options:
- Please select...
- local
- remote
default: 0
validations:
required: false
- type: dropdown
id: server_access_protocol
attributes:
label: Is the server connection HTTP or HTTPS?
options:
- Please select...
- http
- https
default: 0
validations:
required: false

- type: markdown
attributes:
value: |
## Additional
- type: textarea
id: additional_context
attributes:
label: Additional Context
description: Add any other context about the problem here.
validations:
required: false
20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/enhancement-request.md

This file was deleted.

48 changes: 48 additions & 0 deletions .github/ISSUE_TEMPLATE/enhancement-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Enhancement request
description: Suggest a modification to an existing feature
labels: enhancement

body:
- type: checkboxes
id: before-posting
attributes:
label: "This request respects the following points:"
description: All conditions are **required**.
options:
- label: This request is **not** already on [GitHub](https://github.com/jellyfin/jellyfin-roku/labels/enhancement) _(I've searched it)_.
required: true
- label: I agree to follow Jellyfin's [Code of Conduct](https://jellyfin.org/docs/general/community-standards.html#code-of-conduct).
required: true


- type: textarea
attributes:
label: Problem Description
description: Describe the issue you are experiencing or the gap you are trying to address.
placeholder: I often encounter issues when...
validations:
required: true

- type: textarea
attributes:
label: Proposed Solution
description: Provide a detailed description of what you would like to see implemented or changed.
placeholder: Describe the feature or change in detail.
validations:
required: true

- type: textarea
attributes:
label: Alternatives Considered
description: Outline any other approaches you have thought about or explored to solve the problem.
placeholder: Describe any alternative solutions or features.
validations:
required: true

- type: textarea
attributes:
label: Additional Information
description: Include any relevant details, resources, or screenshots that might help in understanding or implementing the request.
placeholder: Add any additional context here.
validations:
required: false
14 changes: 0 additions & 14 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Feature Request
description: Suggest a new feature
labels: feature

body:
- type: checkboxes
id: before-posting
attributes:
label: "This request respects the following points:"
description: All conditions are **required**.
options:
- label: This request is **not** already on [GitHub](https://github.com/jellyfin/jellyfin-roku/labels/enhancement) _(I've searched it)_.
required: true
- label: I agree to follow Jellyfin's [Code of Conduct](https://jellyfin.org/docs/general/community-standards.html#code-of-conduct).
required: true

- type: textarea
attributes:
label: Describe the feature you would like
description: Provide a clear and concise description of the feature you want to see implemented.
validations:
required: true

- type: textarea
id: why-needed
attributes:
label: Why is this feature needed?
description: Explain why this feature would be beneficial and how it improves the project.
placeholder: "Describe why this feature would be useful."
validations:
required: false

- type: textarea
attributes:
label: Additional Context
description: Add any additional context, resources, or screenshots that might help understand or implement the feature.
placeholder: Add any additional context or relevant details here.
validations:
required: false
27 changes: 27 additions & 0 deletions .github/workflows/_build-prod.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Builds the production version of the app
name: build-prod

on:
workflow_call:

jobs:
prod:
if: ${{ github.event_name == 'push' || contains(github.event.pull_request.labels.*.name, 'dependencies') }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4
with:
node-version: "lts/*"
cache: "npm"
- name: NPM install
run: npm ci
- name: Install roku module dependencies
run: npm run ropm
- name: Build app for production
run: npm run build-prod
- uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
with:
name: Jellyfin-Roku-v${{ env.newManVersion }}-${{ github.sha }}
path: ${{ github.workspace }}/build/staging
if-no-files-found: error
18 changes: 18 additions & 0 deletions .github/workflows/_lint-brightscript.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: lint-brightscript

on:
workflow_call:

jobs:
run:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: "lts/*"
cache: "npm"
- run: npm ci
- run: npx ropm install
- run: npm run validate
- run: npm run check-formatting
21 changes: 21 additions & 0 deletions .github/workflows/_lint-json.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: lint-json

on:
workflow_call:

jobs:
run:
runs-on: ubuntu-latest
steps:
- name: Clone github repo
uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: "lts/*"
cache: "npm"
- name: Install npm dependencies
run: npm ci
- name: Install roku package dependencies
run: npx ropm install
- name: Validate JSON syntax
run: npm run lint-json
22 changes: 22 additions & 0 deletions .github/workflows/_lint-markdown.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: lint-markdown

on:
workflow_call:

jobs:
run:
runs-on: ubuntu-latest
steps:
- name: Clone github repo
uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: "lts/*"
cache: "npm"
- name: Install npm dependencies
run: npm ci
- name: Install roku package dependencies
run: npx ropm install
- uses: xt0rted/markdownlint-problem-matcher@1a5fabfb577370cfdf5af944d418e4be3ea06f27 # v3
- name: Lint markdown files
run: npm run lint-markdown
Loading

0 comments on commit 78f072f

Please sign in to comment.