Add setting to enable rewatching in the "Next Up" section

[Johnscaban]

Changes

Add setting to User Interface->General to enable the rewatching of episodes in the "Next Up" section.
Add translation strings for setting.

Issues

Fixes #1778

[jellyfin-bot]

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

[Johnscaban]

Should this pull request be converted to a draft until it can get reviewed so that it doesn't get closed?

[jellyfin-bot]

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

[jellyfin-bot]

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

[Johnscaban]

Should I submit a new pull request?

[cewert]

Sorry this one slipped through the cracks. No need to remake

[Johnscaban]

No problem. Thanks!

[cewert]

This looks great.

Would you mind changing the user setting so that it uses the web client setting by default? The goal is to have all user settings use web client by default with options to override client side.

[Johnscaban]

How should this be done? I'm currently not at my PC, but I would like to get an idea of how to implement your requested changes.

[cewert]

First step is figuring out how to access web client setting. I don't know for sure but I think the web client setting for rewatched should already be saved to the global session in either m.global.session.user.Policy or m.global.session.user.Configuration.

Then you'd need to modify the user setting to a radio selector instead of a bool. That way you can add a third option to the setting - Use web client setting(default), enabled, and disabled.

Then you would have to tweak your code to use the web client setting from m.global.session.user as needed based on the user setting.

Does that make sense?

[Johnscaban]

Okay, so I searched in both m.global.session.user.Policy and m.global.session.user.Configuration when they get printed to the console when a user logs in, and there is no field for the rewatched setting. Am I looking in the right place?

[cewert]

I forgot the display settings come from a different API endpoint and aren't saved to the session var https://github.com/jellyfin/jellyfin-roku/blob/master/source/utils/session.bs#L232

but there still isn't a setting for rewatched so it looks like we don't have access to the web client setting :(

[Johnscaban]

Sorry I forgot about the translations.

[cewert]

Thanks for the PR!