fix: type errors

Signed-off-by: Fernando Fernández <[email protected]>
jellyfin · Jan 10, 2025 · 46cb7c9 · 46cb7c9
1 parent 60ba9fe
commit 46cb7c9
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 6 deletions.
diff --git a/frontend/src/plugins/workers/blurhash-decoder.worker.ts b/frontend/src/plugins/workers/blurhash-decoder.worker.ts
@@ -1,3 +1,5 @@
+/// <reference lib="WebWorker" />
+
 import { decode } from 'blurhash';
 import { expose } from 'comlink';
 import { sealed } from '@jellyfin-vue/shared/validation';

diff --git a/frontend/src/plugins/workers/canvas-drawer.worker.ts b/frontend/src/plugins/workers/canvas-drawer.worker.ts
@@ -1,3 +1,5 @@
+/// <reference lib="WebWorker" />
+
 import { expose } from 'comlink';
 import { sealed } from '@jellyfin-vue/shared/validation';
 

diff --git a/frontend/src/plugins/workers/generic.worker.ts b/frontend/src/plugins/workers/generic.worker.ts
@@ -1,3 +1,5 @@
+/// <reference lib="WebWorker" />
+
 import { expose } from 'comlink';
 import { sealed } from '@jellyfin-vue/shared/validation';
 import { parseVttFile } from './generic/subtitles';

diff --git a/frontend/src/plugins/workers/generic/subtitles.ts b/frontend/src/plugins/workers/generic/subtitles.ts
@@ -1,3 +1,5 @@
+/// <reference lib="WebWorker" />
+
 /**
  * Helper for subtitle manipulation and subtitle-related utility functions
  */

diff --git a/frontend/tsconfig.json b/frontend/tsconfig.json
@@ -3,9 +3,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "lib": [
-      "ESNext",
-      "DOM",
-      "WebWorker"
+      "DOM"
     ],
     "types": [
       "axios",

diff --git a/packages/configs/src/lint/rules/base.ts b/packages/configs/src/lint/rules/base.ts
@@ -31,7 +31,7 @@ export function getBaseConfig(packageName: string, forceCache = !CI_environment,
    * correct flags for each monorepo package.
    * We check for eslint directly to avoid messing up with other packages reading this file, like @eslint/config-inspector.
    */
-  if (cliOverrides && basename(process.argv[1]) === 'eslint') {
+  if (cliOverrides && process.argv[1] && basename(process.argv[1]) === 'eslint') {
     const newArgs = process.argv.slice(1);
 
     if (forceCache && !(newArgs.includes('--cache') && newArgs.includes('--cache-location'))) {
@@ -48,7 +48,7 @@ export function getBaseConfig(packageName: string, forceCache = !CI_environment,
 
     const argsHaveChanged = new Set(newArgs).difference(new Set(process.argv.slice(1))).size > 0;
 
-    if (argsHaveChanged) {
+    if (argsHaveChanged && process.argv[0]) {
       console.log();
 
       const result = spawnSync(process.argv[0], newArgs, {

diff --git a/packages/configs/src/lint/rules/i18n.ts b/packages/configs/src/lint/rules/i18n.ts
@@ -1,4 +1,5 @@
 import type { Linter } from 'eslint';
+// @ts-expect-error - The original plugin doesn't have types
 import i18nPlugin from '@intlify/eslint-plugin-vue-i18n';
 import { vueAndTsFiles } from '../shared';
 

diff --git a/packages/ui-toolkit/src/components/JVirtual/index.vue b/packages/ui-toolkit/src/components/JVirtual/index.vue
@@ -229,7 +229,7 @@ const scrollTargets = computed(() => {
  * == VIRTUAL SCROLLING LOGIC ==
  */
 useResizeObserver(probeRef, (entries) => {
-  itemRect.value = entries[0].contentRect;
+  itemRect.value = entries[0]?.contentRect;
 });
 
 /**

diff --git a/packages/ui-toolkit/src/components/JVirtual/j-virtual.worker.ts b/packages/ui-toolkit/src/components/JVirtual/j-virtual.worker.ts
@@ -1,3 +1,5 @@
+/// <reference lib="WebWorker" />
+
 import { expose } from 'comlink';
 import { sealed } from '@jellyfin-vue/shared/validation';
 import { getItemOffsetByIndex, type ResizeMeasurement, type BufferMeta, type InternalItem } from './pipeline';

diff --git a/packages/ui-toolkit/tsconfig.json b/packages/ui-toolkit/tsconfig.json
@@ -2,6 +2,9 @@
   "extends": "@jellyfin-vue/configs/typescript",
   "compilerOptions": {
     "baseUrl": ".",
+    "lib": [
+      "DOM"
+    ],
     "types": [
       "vite/client",
       "vue"