migrate setup.py to pyproject.toml #1472
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelmer
requested changes
Jan 3, 2025
| tests_require.extend(["gevent", "geventhttpclient", "setuptools>=17.1"]) | ||
|
|
||
|
|
||
| optional = os.environ.get("CIBUILDWHEEL", "0") != "1" |
| optional = os.environ.get("CIBUILDWHEEL", "0") != "1" | ||
|
|
||
| # Ideally, setuptools would just provide a way to do this | ||
| if "PURE" in os.environ or "--pure" in sys.argv: |
There was a problem hiding this comment.
Here as well, please preserve support for the --puro flag and PURE environment variable.
| else: | ||
| setup_requires = ["setuptools_rust"] | ||
| # We check for egg_info since that indicates we are running prepare_metadata_for_build_* | ||
| if "egg_info" in sys.argv: |
|
Hmm, so we need to produce two different type of wheel depending on the flags passed at build time? I will look for it, but I am afraid that is not something available out of the box with static config. |
|
It's not the creation of wheels - individual users might want to do a non-wheel local build with one of these options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an initiative of my own.