Add forward reference annotation detection #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for parsing forward references in type annotations and using them for the detection algorithm.
Description
Hi, I'd like to add the support for forward references so I would appreciate it if you could take a look at this draft.
I understand that it has been discussed but I think it's worth reconsidering, given the timeframe (the original discussion is from 2020) and further adoption of new Python versions.
Personally, this blocks the usage of Vulture as it either forces you to adopt a new standard (
from __future__ import annotations
instead ofif TYPE_CHECKING:...
) or deal with a lot of false positives if you don't (or can't).I know that in the original discussion, there's been concerns about the issues that this could open up so I've tried to cover some basic cases but I'm all for for covering more.
Let me know if this approach makes sense to you.
Related Issue
Checklist:
pre-commit run --all-files
to format and lint my code.