-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(buildDockerAndPublishImage.groovy): fix ath build #745
Conversation
export IMAGE_DEPLOY_NAME \ | ||
TAG_NAME \ | ||
BAKE_TARGETPLATFORMS \ | ||
IMAGE_DOCKERFILE \ | ||
IMAGE_DIR \ | ||
GIT_COMMIT_REV \ | ||
GIT_SCM_URL \ | ||
BUILD_DATE \ | ||
SCM_URI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export IMAGE_DEPLOY_NAME \ | |
TAG_NAME \ | |
BAKE_TARGETPLATFORMS \ | |
IMAGE_DOCKERFILE \ | |
IMAGE_DIR \ | |
GIT_COMMIT_REV \ | |
GIT_SCM_URL \ | |
BUILD_DATE \ | |
SCM_URI | |
export IMAGE_DEPLOY_NAME \ | |
TAG_NAME \ | |
BAKE_TARGETPLATFORMS \ | |
IMAGE_DOCKERFILE \ | |
IMAGE_DIR \ | |
GIT_COMMIT_REV \ | |
GIT_SCM_URL \ | |
BUILD_DATE \ | |
SCM_URI |
nitpick: formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet where did it failed but the commit acf5a06 broke the windows build: https://infra.ci.jenkins.io/job/docker-jobs/job/docker-inbound-agents/job/main/178/
But the ATH build is fixed by this change 👍
seem like linting with absolute path is not working :
still don't get how I missed it during my test, it happend in the build I launched myself ... thanks @dduportal for catching it !
|
this new version go through docker inbound agents (windows) build : https://infra.ci.jenkins.io/job/docker-jobs/job/docker-inbound-agents/job/main/182/console lets try again the others :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like your fix does the job 👏
as per jenkinsci/acceptance-test-harness#1356 (comment)
and following #739
this should correct the bug in the Path due to the absolute vs relative definition
tested on wiki (default path): https://infra.ci.jenkins.io/job/docker-jobs/job/docker-confluence-data/job/main/131/pipeline-graph/
tested on ATH (manually defined path): https://infra.ci.jenkins.io/job/docker-jobs/job/acceptance-test-harness/job/master/289/pipeline-graph/
tested on docker-inbound-agent (windows/legacy build): https://infra.ci.jenkins.io/job/docker-jobs/job/docker-inbound-agents/job/main/178/pipeline-console/