[JENKINS-64150] Fix blank manifest view #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abioteau
force-pushed
the
bugfix/blank-manifest-view
branch
2 times, most recently
from
82d5de1 to
48e9a3b
Compare
|
Hi @francoisferrand, could you have a look on this PR? |
abioteau
force-pushed
the
bugfix/blank-manifest-view
branch
from
48e9a3b to
5ceb8fe
Compare
francoisferrand
requested changes
May 30, 2022
| @@ -47,7 +48,7 @@ public class ManifestAction implements RunAction2, Serializable, BuildBadgeActio | |||
| private static final long serialVersionUID = 1; | |||
|
|
|||
| private transient Run<?, ?> run; | |||
| private transient RevisionState revisionState; | |||
| private RevisionState revisionState; | |||
There was a problem hiding this comment.
revisionState is a large object, which should not be persisted I think; and it will anyway be re-loaded on call to setIndex, hence the transient annotation.
Isn't the @DataBoundSetter annotation enough to fix the problem here?
There was a problem hiding this comment.
I don't know, I cannot test my fix.
I add @DataBoundSetter annotation to follow your comment in #75 but ManifestAction is not created from StaplerRequest.bindJSON() or StaplerRequest.bindParameters(), so I don't think setIndex will be call.
So I remove transient annotation to keep revisionState object has setIndex is only call at creation of ManifestAction.
|
Issue solved by #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As describe on #75 and on JENKINS-64150, the repo manifest informations are blanked on existing jobs after restart of Jenkins server on release 1.14.0. It is related to changes made on #62.