Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a batch_add feature to avoid sort for each virtual node addition #21

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

dzhao
Copy link

@dzhao dzhao commented Nov 9, 2023

in some of our setups we need to increase virtual nodes to 10k to get a better distribution of the data. This is to add a batch API to speedup the building process

@jeromefroe
Copy link
Owner

@dzhao the PR looks good to me. Can you just format your code and add a test before we merge?

@dzhao
Copy link
Author

dzhao commented Nov 10, 2023

test added

@jeromefroe
Copy link
Owner

Thanks for the contribution @dzhao!

@jeromefroe jeromefroe merged commit 6cc61fe into jeromefroe:master Nov 12, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants