Fix a bunch of compilation warnings from clang++. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-azarchs
force-pushed
the
master
branch
2 times, most recently
from
9f027e4 to
e80b780
Compare
Mostly these are inconsistent usage of int vs. unsigned int vs. long vs. size_t, plus one abstract base class that needed a virtual destructor and a few logical expressions for which clang considers parentheses to be necessary for clarity. Also fix a couple of issues found by clang-tidy, mostly related to narrowing integer conversions. Avoided touching things that might affect the API or floating point results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly these are inconsistent usage of int vs. unsigned int vs. long vs.
size_t, plus one abstract base class that needed a virtual destructor
and a few logical expressions for which clang considers parentheses to
be necessary for clarity.
Also fix a couple of issues found by clang-tidy, mostly related to
narrowing integer conversions. Avoided touching things that might
affect the API or floating point results.