Cleanup

jimsmart · Apr 12, 2021 · 1ed2d24 · 1ed2d24
1 parent 97bbc51
commit 1ed2d24
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/dialect_oracle.go b/dialect_oracle.go
@@ -4,6 +4,8 @@ import (
 	"database/sql"
 )
 
+// TODO(js) Are we querying the correct tables? See https://dba.stackexchange.com/questions/153436/i-want-to-see-all-tables-of-db-but-no-system-tables
+
 const oracleAllColumns = `SELECT * FROM %s WHERE 1=0`
 
 const oracleTableNamesWithSchema = `

diff --git a/dialect_sqlite.go b/dialect_sqlite.go
@@ -4,6 +4,8 @@ import (
 	"database/sql"
 )
 
+// TODO(js) Can we see tables in an attached database? How are their names handled? See https://sqlite.org/lang_naming.html
+
 const sqliteAllColumns = `SELECT * FROM %s LIMIT 0`
 
 const sqliteTableNamesWithSchema = `

diff --git a/schema_mssql_test.go b/schema_mssql_test.go
@@ -16,7 +16,6 @@ var _ = Describe("schema", func() {
 	Context("using github.com/denisenkom/go-mssqldb (Microsoft SQL-Server)", func() {
 
 		const (
-			// user = "mssql_test_user"
 			user = "test_user"
 			pass = "Password-123"
 			host = "localhost"