Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test to compare with late chunking in the API #8

Merged
merged 9 commits into from
Sep 20, 2024
Merged

test: add test to compare with late chunking in the API #8

merged 9 commits into from
Sep 20, 2024

Conversation

guenthermi
Copy link
Member

@guenthermi guenthermi commented Sep 19, 2024 •
edited
Loading

Adds a test for comparing the late chunking implemented in this repository to the API

violenil
violenil reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@violenil violenil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Now that the GH workflow changes are merged, you can add the JINA_API_TOKEN to the GH secrets so this test can run in the CI.

@guenthermi guenthermi changed the base branch from feat-support-v3 to main September 20, 2024 11:25
@guenthermi guenthermi requested a review from violenil September 20, 2024 13:40
@guenthermi guenthermi merged commit c5e91ed into main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violenil violenil Awaiting requested review from violenil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guenthermi @violenil