Fix quadric memcpy on toJson (#259)

* fix quadratic speed * add reserve
jinja2cpp · Sep 15, 2024 · e98b3b5 · e98b3b5
1 parent b32fbde
commit e98b3b5
Showing 1 changed file with 14 additions and 21 deletions.
diff --git a/src/serialize_filters.cpp b/src/serialize_filters.cpp
@@ -152,28 +152,21 @@ InternalValue Serialize::Filter(const InternalValue& value, RenderContext& conte
         DocumentWrapper jsonDoc;
         const auto jsonValue = jsonDoc.CreateValue(value);
         const auto jsonString = jsonValue.AsString(static_cast<uint8_t>(indent));
-        const auto result = std::accumulate(jsonString.begin(), jsonString.end(), ""s, [](const auto &str, const auto &c)
-        {
-            switch (c)
-            {
-            case '<':
-                return str + "\\u003c";
-                break;
-            case '>':
-                return str +"\\u003e";
-                break;
-            case '&':
-                return str +"\\u0026";
-                break;
-            case '\'':
-                return str +"\\u0027";
-                break;
-            default:
-                return str + c;
-                break;
+        std::string result = ""s;
+        result.reserve(jsonString.size());
+        for (char c : jsonString) {
+            if (c == '<') {
+                result.append("\\u003c");
+            } else if (c == '>') {
+                result.append("\\u003e");
+            } else if (c == '&') {
+                result.append("\\u0026");
+            } else if (c == '\'') {
+                result.append("\\u0027");
+            } else {
+                result.push_back(c);
             }
-        });
-
+        }
         return result;
     }